Skip to content

[mimecast] Update ECS version to 8.2 with email fields#2841

Merged
andrewkroh merged 13 commits intoelastic:mainfrom
djordje-adzemovic-devtech:updateecsto8.2
Apr 6, 2022
Merged

[mimecast] Update ECS version to 8.2 with email fields#2841
andrewkroh merged 13 commits intoelastic:mainfrom
djordje-adzemovic-devtech:updateecsto8.2

Conversation

@djordje-adzemovic-devtech
Copy link
Contributor

@djordje-adzemovic-devtech djordje-adzemovic-devtech commented Mar 17, 2022

What does this PR do?

Update ecs verion to 8.2 and implementing best practice for ingesting email fields in pipelines

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@djordje-adzemovic-devtech djordje-adzemovic-devtech requested a review from a team as a code owner March 17, 2022 13:42
@elasticmachine
Copy link

elasticmachine commented Mar 17, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-05T06:47:36.697+0000

  • Duration: 17 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 61
Skipped 0
Total 61

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

efd6
efd6 previously requested changes Mar 17, 2022
@efd6
Copy link
Contributor

efd6 commented Mar 17, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Mar 18, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Mar 20, 2022

Please run elastic-package build to bring the README.md up-to-date.

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylor-swanson
Copy link
Contributor

/test

- mimecast.as.asn
- mimecast.organization_name
- mimecast.event_info_parts
- mimecast.rest_of_event_info
Copy link
Contributor

@efd6 efd6 Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this line back in. After that LGTM.

@efd6
Copy link
Contributor

efd6 commented Mar 28, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Mar 28, 2022

@djordje-adzemovic-devtech You will need to update the generated docs: README.md is outdated. Rebuild the package with 'elastic-package build' from the CI.

@djordje-adzemovic-devtech
Copy link
Contributor Author

Is this ok to be merged? @efd6 @taylor-swanson

@andrewkroh andrewkroh changed the title Update ecs verion to 8.2 and implementing best practice for ingesting… [mimecast] Update ECS version to 8.2 with email fields Mar 30, 2022
@andrewkroh
Copy link
Member

/test

@efd6
Copy link
Contributor

efd6 commented Apr 3, 2022

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for an approval from @efd6 then it can be merged.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@andrewkroh andrewkroh merged commit b0f94db into elastic:main Apr 6, 2022
@andrewkroh andrewkroh added the Integration:mimecast Mimecast (Partner supported) label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:mimecast Mimecast (Partner supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants