[mimecast] Update ECS version to 8.2 with email fields#2841
Merged
andrewkroh merged 13 commits intoelastic:mainfrom Apr 6, 2022
djordje-adzemovic-devtech:updateecsto8.2
Merged
[mimecast] Update ECS version to 8.2 with email fields#2841andrewkroh merged 13 commits intoelastic:mainfrom djordje-adzemovic-devtech:updateecsto8.2
andrewkroh merged 13 commits intoelastic:mainfrom
djordje-adzemovic-devtech:updateecsto8.2
Conversation
… email fields in pipelines
efd6
previously requested changes
Mar 17, 2022
packages/mimecast/data_stream/dlp_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/siem_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/ttp_ap_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/ttp_ip_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/ttp_url_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Contributor
|
/test |
Contributor
|
/test |
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Contributor
|
Please run |
Contributor
|
/test |
efd6
reviewed
Mar 21, 2022
| - mimecast.as.asn | ||
| - mimecast.organization_name | ||
| - mimecast.event_info_parts | ||
| - mimecast.rest_of_event_info |
Contributor
There was a problem hiding this comment.
Please add this line back in. After that LGTM.
…d rerun test and update README
Closed
Contributor
|
/test |
Contributor
|
@djordje-adzemovic-devtech You will need to update the generated docs: |
Contributor
Author
|
Is this ok to be merged? @efd6 @taylor-swanson |
andrewkroh
reviewed
Mar 30, 2022
Member
|
/test |
4 tasks
…/integrations into updateecsto8.2
efd6
reviewed
Apr 3, 2022
packages/mimecast/data_stream/dlp_logs/_dev/test/pipeline/test-dlp-logs.log-expected.json
Show resolved
Hide resolved
Contributor
|
/test |
andrewkroh
approved these changes
Apr 5, 2022
andrewkroh
approved these changes
Apr 5, 2022
Member
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM. Will wait for an approval from @efd6 then it can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update ecs verion to 8.2 and implementing best practice for ingesting email fields in pipelines
Checklist
changelog.ymlfile.