Skip to content

Fix mapper_parsing_exception when parsing event_time#2813

Merged
r00tu53r merged 3 commits intoelastic:mainfrom
r00tu53r:fix/event-time-mapping-error
Mar 10, 2022
Merged

Fix mapper_parsing_exception when parsing event_time#2813
r00tu53r merged 3 commits intoelastic:mainfrom
r00tu53r:fix/event-time-mapping-error

Conversation

@r00tu53r
Copy link
Contributor

@r00tu53r r00tu53r commented Mar 10, 2022

What does this PR do?

The PR fixes the error with the way date processor is used. The date processor in the pipeline sets the @timestamp field from the given format but leaves the event_time field in its SQL server format which is not strict_date_optional_time||epoch_millis as expected by elasticsearch default date formats. The fix is to remove this field as the value has been stored in @timestamp.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Run pipeline tests elastic-package test pipeline
  • Run system tests manually by setting up a windows agent with SQL Server on it.

@r00tu53r r00tu53r added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:microsoft_sqlserver Microsoft SQL Server labels Mar 10, 2022
@r00tu53r r00tu53r requested a review from P1llus March 10, 2022 09:08
@r00tu53r r00tu53r self-assigned this Mar 10, 2022
@r00tu53r r00tu53r requested a review from a team as a code owner March 10, 2022 09:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-10T09:18:09.339Z&rangeTo=2022-03-10T09:38:09.339Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=e0fa31c1c6507da6aad959f8a6d5b7d0&transactionId=c346281a13e05da8)

Expand to view the summary

Build stats

  • Start Time: 2022-03-10T09:28:09.339+0000

  • Duration: 11 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to regenerate the test expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:microsoft_sqlserver Microsoft SQL Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants