Skip to content

[TI_Cybersixgill] Change from API to TAXII for the integration#2771

Merged
P1llus merged 5 commits intoelastic:mainfrom
P1llus:package_cybersixgill_taxi
Mar 10, 2022
Merged

[TI_Cybersixgill] Change from API to TAXII for the integration#2771
P1llus merged 5 commits intoelastic:mainfrom
P1llus:package_cybersixgill_taxi

Conversation

@P1llus
Copy link
Member

@P1llus P1llus commented Mar 7, 2022

What does this PR do?

The initial integration used to communicate with a third party python script, in collaboration with Cybersixgill we have converted this integration to rather use the TAXII server directly, this removes all third party tools requirements instead.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

The dashboards and fields are the same, but the ingest pipeline had to be rewritten to replace the functionality initially found in the python script

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member Author

P1llus commented Mar 7, 2022

Awaiting feedback from Cybersixgill on a replacement for the Range header, to retrieve more items than the current default limit of 100.
Everything else is ready to be reviewed though.

@elasticmachine
Copy link

elasticmachine commented Mar 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-09T08:06:07.482Z&rangeTo=2022-03-09T08:26:07.482Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=80376cdf04e0e636bc5ba90870479668&transactionId=dd603c688b325f58)

Expand to view the summary

Build stats

  • Start Time: 2022-03-09T08:16:07.482+0000

  • Duration: 13 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus
Copy link
Member Author

P1llus commented Mar 9, 2022

I have now tested this with 90 days worth of data working successfully, it is fully ready for review

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need reformatting, check is complaining.

@P1llus
Copy link
Member Author

P1llus commented Mar 9, 2022

I have a demo scheduled sometime tomorrow and will proceed with merging after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants