Add check for github codeowners file#2768
Merged
jsoriano merged 9 commits intoelastic:mainfrom Mar 14, 2022
Merged
Conversation
andrewkroh
reviewed
Mar 4, 2022
mtojek
reviewed
Mar 4, 2022
mtojek
approved these changes
Mar 7, 2022
Contributor
mtojek
left a comment
There was a problem hiding this comment.
A few nit-picks, which can be ignored or considered as a further improvement.
jsoriano
commented
Mar 10, 2022
| mg.Deps(build) | ||
| mg.Deps(format) | ||
| mg.Deps(modTidy) | ||
| mg.Deps(goTest) |
Member
Author
There was a problem hiding this comment.
I didn't find if go tests were executed in CI. As all the Go code is somehow related to the magefile, I am adding it here, but I guess this could be added somewhere in the Jenkinsfile too.
mtojek
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds checks for owners:
.github/CODEOWNERS..github/CODEOWNERS.Manual exceptions as multiple owners in the github file, or owners per subdirectory are still allowed.
How to test this PR locally
mage checkRelated issues
Screenshots