Skip to content

Add check for github codeowners file#2768

Merged
jsoriano merged 9 commits intoelastic:mainfrom
jsoriano:codeowners-check
Mar 14, 2022
Merged

Add check for github codeowners file#2768
jsoriano merged 9 commits intoelastic:mainfrom
jsoriano:codeowners-check

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Mar 4, 2022

What does this PR do?

It adds checks for owners:

  • All manifests in the repo must have a github owner.
  • All packages must have an entry in .github/CODEOWNERS.
  • Owner specified in the manifest must be one of the owners specified for a package in .github/CODEOWNERS.

Manual exceptions as multiple owners in the github file, or owners per subdirectory are still allowed.

How to test this PR locally

mage check

Related issues

Screenshots

@jsoriano jsoriano requested a review from ruflin March 4, 2022 13:08
@jsoriano jsoriano requested a review from a team as a code owner March 4, 2022 13:08
@jsoriano jsoriano self-assigned this Mar 4, 2022
@elasticmachine
Copy link

elasticmachine commented Mar 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-10T18:11:20.123+0000

  • Duration: 91 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 4379
Skipped 7
Total 4386

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nit-picks, which can be ignored or considered as a further improvement.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also want to improve the Jenkins side.

Consider the hadoop package, it contains a single package and CODEOWNERS. The CI will trigger tests for all packages as the CODEOWNERS file is touched.

mg.Deps(build)
mg.Deps(format)
mg.Deps(modTidy)
mg.Deps(goTest)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find if go tests were executed in CI. As all the Go code is somehow related to the magefile, I am adding it here, but I guess this could be added somewhere in the Jenkinsfile too.

@jsoriano jsoriano requested a review from mtojek March 10, 2022 18:07
@jsoriano jsoriano merged commit 0b4e4dd into elastic:main Mar 14, 2022
@jsoriano jsoriano deleted the codeowners-check branch March 14, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants