[mimecast] Add use cases, docs, and update sample events#2690
Merged
marc-gr merged 15 commits intoelastic:mainfrom Feb 23, 2022
djordje-adzemovic-devtech:after-release-changes
Merged
[mimecast] Add use cases, docs, and update sample events#2690marc-gr merged 15 commits intoelastic:mainfrom djordje-adzemovic-devtech:after-release-changes
marc-gr merged 15 commits intoelastic:mainfrom
djordje-adzemovic-devtech:after-release-changes
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
marc-gr
requested changes
Feb 14, 2022
Contributor
marc-gr
left a comment
marc-gr
left a comment
There was a problem hiding this comment.
Nice additions! Just as a note aside of the comments, I think the changes done in README.md need to be done instead to the _dev/build/... README file.
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
marc-gr
reviewed
Feb 17, 2022
...ges/mimecast/data_stream/audit_events/_dev/test/pipeline/test-audit-events.log-expected.json
Outdated
Show resolved
Hide resolved
marc-gr
reviewed
Feb 22, 2022
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
...ges/mimecast/data_stream/audit_events/_dev/test/pipeline/test-audit-events.log-expected.json
Show resolved
Hide resolved
…ns in pipeline operators
marc-gr
reviewed
Feb 22, 2022
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
marc-gr
reviewed
Feb 22, 2022
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Contributor
|
/test |
Member
|
I'm not sure if you want to do this here, but the the ECS version used in the package should be changed from 1.12.0 to 8.0.0. It's in the ingest pipeline and this file. |
andrewkroh
added
Integration:mimecast
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
changed the title
Contributor
|
/test |
andrewkroh
reviewed
Feb 22, 2022
Contributor
|
/test |
marc-gr
approved these changes
Feb 22, 2022
Contributor
|
/test |
Contributor
|
/test |
marc-gr
approved these changes
Feb 23, 2022
Contributor
|
/test |
P1llus
approved these changes
Feb 23, 2022
Member
P1llus
left a comment
P1llus
left a comment
There was a problem hiding this comment.
LGTM. I only reviewed the generation of the Readme + the 8.0 ecs changes and generation of test data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add use cases for audit events and update sample events and docs.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots