Skip to content

[mimecast] Add 8.0.0 compatibility#2683

Merged
andrewkroh merged 2 commits intoelastic:mainfrom
andrewkroh:mimecast/8-0-compat
Feb 22, 2022
Merged

[mimecast] Add 8.0.0 compatibility#2683
andrewkroh merged 2 commits intoelastic:mainfrom
andrewkroh:mimecast/8-0-compat

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 11, 2022

What does this PR do?

Add 8.0.0 Elastic stack compatibility, fix the Github team name in manifest, and remove the redundant event.ingested from pipelines.

Closes #2679

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Add 8.0.0 Elastic stack compatibility, fix the Github team name in manifest, and remove the redundant `event.ingested` from pipelines.

Closes #2679
@andrewkroh andrewkroh changed the title mimecast - Add 8.0.0 compatibility [mimecast] Add 8.0.0 compatibility Feb 11, 2022
@elasticmachine
Copy link

elasticmachine commented Feb 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-15T03:15:43.068+0000

  • Duration: 28 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 61
Skipped 0
Total 61

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh requested a review from a team February 11, 2022 22:25
value: "{{ _ingest.timestamp }}"
- set:
field: ecs.version
value: "1.12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mimecast not moving to ECS 8.0.0? (all data_stream/*/elasticsearch/ingest_pipeline/default.yml)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should. I guess we missed it. @r00tu53r any reason this one got skipped? Maybe it merged in the middle of the update process.

In any case I think we can upgrade this package to ECS 8.0.0 independently of stack 8.0.0.

@andrewkroh andrewkroh requested a review from a team February 21, 2022 13:02
@@ -6,42 +6,41 @@
"ecs": {
"version": "1.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note elastic/beats#30499 for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:mimecast Mimecast (Partner supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mimecast] Add ^8.0.0 stack compatibility

3 participants