[o365] Better handling of address formats#2669
Merged
adriansr merged 7 commits intoelastic:mainfrom Feb 17, 2022
adriansr:o365_fix_2660
Merged
[o365] Better handling of address formats#2669adriansr merged 7 commits intoelastic:mainfrom adriansr:o365_fix_2660
adriansr merged 7 commits intoelastic:mainfrom
adriansr:o365_fix_2660
Conversation
This removes event.ingested from the pipeline (unnecessary) and re-generates the log so that keys are now sorted, for easier comparison of changes.
Contributor
|
Looks like u made additional changes than I did. I can close mine if u want? |
Contributor
Author
|
Thanks for your PR, @legoguy1000, much appreciated. I took the opportunity to make more changes that I felt necessary in this case, so yes, better keep this one instead.
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
approved these changes
Feb 16, 2022
This was referenced Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(%{NOTSPACE:...}|%{HOSTNAME:...}))::ffff:A.B.C.D).Closes #2660
Relates #2519