Skip to content

Add ML modules to Nginx readme#2662

Merged
lcawl merged 2 commits intoelastic:mainfrom
lcawl:nginx-jobs
Mar 7, 2022
Merged

Add ML modules to Nginx readme#2662
lcawl merged 2 commits intoelastic:mainfrom
lcawl:nginx-jobs

Conversation

@lcawl
Copy link
Copy Markdown
Contributor

@lcawl lcawl commented Feb 9, 2022

What does this PR do?

Adds a table to the readme for the Nginx module, which lists the machine learning modules that are included in the integration. The names and descriptions for these jobs are found in https://github.com/elastic/integrations/blob/main/packages/nginx/kibana/ml_module/nginx-Logs-ml.json

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@lcawl lcawl marked this pull request as ready for review February 9, 2022 17:18
@lcawl lcawl requested a review from peteharverson February 9, 2022 17:18
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-09T17:17:40.175+0000

  • Duration: 20 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl requested a review from bmorelli25 March 3, 2022 17:49
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl requested a review from a team March 3, 2022 21:19
@lcawl lcawl merged commit 1f2658c into elastic:main Mar 7, 2022
@lcawl lcawl deleted the nginx-jobs branch March 7, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants