Skip to content

[cisco_ftd] Change observer type/name to idps/ftd#2551

Merged
andrewkroh merged 7 commits intoelastic:mainfrom
nicpenning:patch-1
Apr 6, 2022
Merged

[cisco_ftd] Change observer type/name to idps/ftd#2551
andrewkroh merged 7 commits intoelastic:mainfrom
nicpenning:patch-1

Conversation

@nicpenning
Copy link
Contributor

@nicpenning nicpenning commented Jan 21, 2022

It appears that the asa was copied over into this pipeline. Also, this is an IDPS (Intrustion Detection and Prevention System) not a firewall.

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@nicpenning
Change Observer to IDPS/FTD instead of Firewall/ASA
0745308 
It appears that the asa was copied over into this pipeline. Also, this is an IDPS (Intrustion Detection and Prevention System) not a firewall.
@elasticmachine
Copy link

elasticmachine commented Jan 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-06T19:10:49.119+0000

  • Duration: 14 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 24, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

LaZyDK
LaZyDK approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@LaZyDK LaZyDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh requested a review from a team as a code owner April 6, 2022 18:41
@andrewkroh andrewkroh changed the title Change Observer to IDPS/FTD instead of Firewall/ASA [cisco_ftd] Change observer type/name to idps/ftd Apr 6, 2022
@andrewkroh
Copy link
Member

andrewkroh commented Apr 6, 2022

/test

@andrewkroh
Remove event.ingested from pipeline
e693464
@andrewkroh
Add missing event.* fields
211f43b
@andrewkroh
Update generated docs and expected pipeline docs
96a9c53 
[git-generate]

cd packages/cisco_ftd
elastic-package build
elastic-package test pipeline -g
@andrewkroh andrewkroh merged commit 4dac946 into elastic:main Apr 6, 2022
@andrewkroh andrewkroh mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

+1 more reviewer

@LaZyDK LaZyDK LaZyDK approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Integration:cisco_ftd Cisco FTD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicpenning @elasticmachine @andrewkroh @LaZyDK @jamiehynds