Skip to content

[windows] Add provider name check to forwarded/security conditional #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylor-swanson merged 2 commits into from
Jan 19, 2022
Merged

[windows] Add provider name check to forwarded/security conditional #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d6e891
[Windows] Add provider name check to forwarded/security conditional
taylor-swanson Jan 13, 2022
0ccf6f0
Update changelog with PR
taylor-swanson Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/windows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.7.0"
changes:
- description: Add provider name check to forwarded/security conditional.
type: enhancement
link: https://github.com/elastic/integrations/pull/2527
- version: "1.6.0"
changes:
- description: Expose winlog input language option.
Expand Down
2 changes: 1 addition & 1 deletion packages/windows/data_stream/forwarded/elasticsearch/ingest_pipeline/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Pipeline for Windows forwarded Event Logs
processors:
- pipeline:
name: '{{ IngestPipeline "security" }}'
if: ctx?.winlog?.channel != null && ctx?.winlog?.channel == "Security"
if: ctx?.winlog?.channel != null && ctx?.winlog?.channel == "Security" && ctx?.winlog?.provider_name != null && ["Microsoft-Windows-Eventlog", "Microsoft-Windows-Security-Auditing"].contains(ctx?.winlog?.provider_name)
Copy link
Contributor

@efd6 efd6 Jan 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there cases where channel is "Security" but provider_name isn't /Microsoft-Windows-(Eventlog|Security-Auditing)/?

Copy link
Contributor Author

@taylor-swanson taylor-swanson Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. For forwarded events I'm not sure if this is the case or not. The other provider name we know of that can appear in the Security channel is AD FS, and we know we don't want it enriched with this pipeline. I was mostly replicating the logic from other pipelines here (the ones in System and Winlogbeat). I think this is still safe since we don't want to enrich any other providers other than the ones we know of. Those are listed here: https://windows-event-explorer.app.elstc.co/channel/Security

- pipeline:
name: '{{ IngestPipeline "powershell" }}'
if: ctx?.winlog?.channel != null && ctx?.winlog?.channel == "Windows PowerShell"
Expand Down
2 changes: 1 addition & 1 deletion packages/windows/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: windows
title: Windows
version: 1.6.0
version: 1.7.0
description: Collect logs and metrics from Windows OS and services with Elastic Agent.
type: integration
categories:
Expand Down