[GCP] Add GCP Compute Metricset by legoguy1000 · Pull Request #2301 · elastic/integrations

legoguy1000 · 2021-12-02T04:20:33Z

What does this PR do?

Adds GCP Compute Metricset

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

[ ]

How to test this PR locally

Related issues

Relates Migrate some Metricbeat modules to GCP package #490

Screenshots

elasticmachine · 2021-12-02T04:24:59Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-12-29T21:30:53.845+0000
Duration: 18 min 21 sec
Commit: 32e57ee

Test stats 🧪

Test	Results
Failed	0
Passed	43
Skipped	0
Total	43

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

legoguy1000 · 2021-12-02T04:29:21Z

@endorama next one ready for your review

legoguy1000 · 2021-12-13T18:38:45Z

@endorama Any thoughts on this one?

elasticmachine · 2021-12-14T19:04:05Z

Pinging @elastic/integrations (Team:Integrations)

kaiyan-sheng

Looks good to me! Waiting for @endorama 's review 🙂

kaiyan-sheng · 2021-12-14T19:11:29Z

/test

packages/gcp/data_stream/compute/agent/stream/stream.yml.hbs

packages/gcp/data_stream/compute/fields/agent.yml

packages/gcp/docs/compute.md

endorama · 2021-12-20T16:19:24Z

Sorry for the delay, I've been stuck adding tests to the billing data stream. I did a first round of review and noticed something strange with field names.

legoguy1000 · 2021-12-20T17:09:24Z

@endorama updates pushed

endorama · 2021-12-20T17:14:19Z

@legoguy1000 thanks! May you please check dashboards too? It seems those still contains old values.

legoguy1000 · 2021-12-21T14:21:41Z

@endorama Dashboards should be updated.

endorama

Thank you for the updates! I see tests are still failing, but wasn't able to pin point the exact issue.

endorama · 2021-12-24T11:57:03Z

rerunning tests in case has been a transactional issue.

/test

endorama · 2021-12-28T14:37:07Z

I've been able to update the sample data and working on a PR in beats to update them.

legoguy1000 · 2021-12-28T15:02:47Z

I've been able to update the sample data and working on a PR in beats to update them.

Cool, feel free to push that update to this branch or send it to me and I'll update it.

endorama · 2021-12-29T17:43:20Z

@legoguy1000 I started working on updating the sample events in beats in the linked PR, but is taking longer than expected. In any case I've been able to update the compute metricset sample events, so you may take those to update this PR, and I expect that to work. Meanwhile I'll work on updating the beats side too.

legoguy1000 · 2021-12-29T22:25:44Z

@endorama looks like it worked.

endorama · 2021-12-31T16:11:26Z

Thank you! I'm merging this as is good to go, I'll open a separate PR with testing for this data stream.

@legoguy1000 next week I'll be off, so feel free to open the next PR but I won't be able to look at it before the 10th of January. Thank you for the contribution and happy new year!

This commit has been changed to remove changes to README included in #2141 to allow documentation changes from #2842

* gcp: stub logs and metrics doc files * [GCP] Add GCP Billing Metricset (#2141) * [GCP] Add GCP Compute Metricset (#2301) * [GCP] Add GCP Billing Metricset (#2141) * [GCP] Add GCP Compute Metricset (#2301) * Add firestore data_stream * Fix formatting issue * Add gcp tests env vars in Jenkinsfile * Add missing env fields * Update terraform deployer * Update system test * Fix credentials json field * Format & add period * Update docs * Update default period for firestoer * Update terraform deployer * Remove period from system test * Update manifest version * Update manifest file * Add default project id * Fix owner * Update audit docs * Fix terraform deployer * Remove redundant alternative host * Fix project variable * Remove default project string * Remove firestore datastream tests * Revert "Add gcp tests env vars in Jenkinsfile" This reverts commit ceea735. Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co> Co-authored-by: Alex Resnick <adr8292@gmail.com>

This commit has been changed to remove changes to README included in #2141 to allow documentation changes from #2842

legoguy1000 marked this pull request as ready for review December 2, 2021 04:29

This was referenced Dec 2, 2021

[GCP] Add GCP GKE Metricset #2307

Closed

[GCP] Add GCP Load Balancer Metricset #2308

Closed

[GCP] Add GCP PubSub metricset #2309

Closed

[GCP] Add GCP Storage Metricset #2310

Closed

endorama force-pushed the gcp-metrics branch from 6d69fec to bedf243 Compare December 3, 2021 14:36

legoguy1000 mentioned this pull request Dec 4, 2021

[GCP] Add GCP Custom Metricset #2314

Closed

4 tasks

legoguy1000 added 3 commits December 9, 2021 14:59

Add GCP Compute metricset

2f57518

minor fix

529a49c

remove old readme's

3948e06

legoguy1000 force-pushed the 490-gcp-compute branch from c1b02b2 to 3948e06 Compare December 9, 2021 15:00

kaiyan-sheng requested a review from endorama December 14, 2021 19:03

kaiyan-sheng added the Team:Integrations Label for the Integrations team label Dec 14, 2021

kaiyan-sheng approved these changes Dec 14, 2021

View reviewed changes

fix fields

043e43c

masci assigned endorama Dec 16, 2021

endorama requested changes Dec 20, 2021

View reviewed changes

packages/gcp/data_stream/compute/agent/stream/stream.yml.hbs Outdated Show resolved Hide resolved

packages/gcp/data_stream/compute/fields/agent.yml Outdated Show resolved Hide resolved

packages/gcp/docs/compute.md Outdated Show resolved Hide resolved

update fields and resolve comments

60d37b1

Fix dashboards

b95671c

endorama reviewed Dec 24, 2021

View reviewed changes

endorama mentioned this pull request Dec 29, 2021

[Metricbeat] gcp: update sample datas elastic/beats#29637

Closed

6 tasks

legoguy1000 force-pushed the 490-gcp-compute branch from e2554d4 to c908ec2 Compare December 29, 2021 21:13

update sample data

32e57ee

legoguy1000 force-pushed the 490-gcp-compute branch from c908ec2 to 32e57ee Compare December 29, 2021 21:30

endorama merged commit 7567409 into elastic:gcp-metrics Dec 31, 2021

legoguy1000 deleted the 490-gcp-compute branch December 31, 2021 16:26

endorama pushed a commit that referenced this pull request Feb 1, 2022

[GCP] Add GCP Compute Metricset (#2301)

ddbbb84

endorama mentioned this pull request Feb 16, 2022

[gcp] Migrate some gcp beat metricset to data streams #2707

Merged

4 tasks

endorama mentioned this pull request Mar 2, 2022

Migrate some Metricbeat modules to GCP package #490

Closed

11 tasks

endorama pushed a commit that referenced this pull request Mar 17, 2022

[GCP] Add GCP Compute Metricset (#2301)

c414665

endorama pushed a commit that referenced this pull request Mar 22, 2022

[GCP] Add GCP Compute Metricset (#2301)

376a5e9

This commit has been changed to remove changes to README included in #2141 to allow documentation changes from #2842

gpop63 pushed a commit to gpop63/integrations that referenced this pull request Mar 23, 2022

[GCP] Add GCP Compute Metricset (elastic#2301)

6a2821f

gpop63 pushed a commit to gpop63/integrations that referenced this pull request Mar 23, 2022

[GCP] Add GCP Compute Metricset (elastic#2301)

3e4354e

endorama pushed a commit that referenced this pull request Apr 5, 2022

[GCP] Add GCP Compute Metricset (#2301)

330797b

This commit has been changed to remove changes to README included in #2141 to allow documentation changes from #2842

endorama pushed a commit that referenced this pull request Jun 9, 2022

[GCP] Add GCP Compute Metricset (#2301)

8947679

This commit has been changed to remove changes to README included in #2141 to allow documentation changes from #2842

endorama pushed a commit that referenced this pull request Jul 12, 2022

[GCP] Add GCP Compute Metricset (#2301)

fa41120

This commit has been changed to remove changes to README included in #2141 to allow documentation changes from #2842

andrewkroh mentioned this pull request Jul 18, 2022

[production] Promote packages from snapshot (gcp-2.0.0, zscaler_zia-2.3.0) elastic/package-storage#4888

Closed

This was referenced Jul 21, 2022

[GCP] Convert GCP GKE metricset from lightweight #3793

Merged

[GCP] Add GCP Custom Metricset #3794

Closed

andrewkroh mentioned this pull request Jul 26, 2022

[production] Promote many packages from snapshot elastic/package-storage#5004

Merged

Conversation

legoguy1000 commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Screenshots

Uh oh!

elasticmachine commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

legoguy1000 commented Dec 2, 2021

Uh oh!

legoguy1000 commented Dec 13, 2021

Uh oh!

elasticmachine commented Dec 14, 2021

Uh oh!

kaiyan-sheng left a comment

Choose a reason for hiding this comment

Uh oh!

kaiyan-sheng commented Dec 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

endorama commented Dec 20, 2021

Uh oh!

legoguy1000 commented Dec 20, 2021

Uh oh!

endorama commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legoguy1000 commented Dec 21, 2021

Uh oh!

endorama left a comment

Choose a reason for hiding this comment

Uh oh!

endorama commented Dec 24, 2021

Uh oh!

endorama commented Dec 28, 2021

Uh oh!

legoguy1000 commented Dec 28, 2021

Uh oh!

endorama commented Dec 29, 2021

Uh oh!

legoguy1000 commented Dec 29, 2021

Uh oh!

endorama commented Dec 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

legoguy1000 commented Dec 2, 2021 •

edited

Loading

elasticmachine commented Dec 2, 2021 •

edited

Loading

endorama commented Dec 20, 2021 •

edited

Loading