Skip to content

Fix issues found while migrating to simplified API #17656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsoriano merged 2 commits into from
Mar 5, 2026
Merged

Fix issues found while migrating to simplified API #17656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3f48b9
Fix issues found while migrating to simplified API
jsoriano Mar 4, 2026
00dd715
Force use of legacy API
jsoriano Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ft_exchange_online_message_trace/data_stream/log/_dev/test/system/test-logfile-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
service: exchange-online-logfile
input: logfile
vars:
local_domains:
- "contoso.com"
data_stream:
vars:
preserve_original_event: true
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/archive_search_logs/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/audit_events/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/dlp_logs/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/siem_logs/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion ...es/mimecast/data_stream/threat_intel_malware_customer/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/threat_intel_malware_grid/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/ttp_ap_logs/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/ttp_ip_logs/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 1 addition & 1 deletion packages/mimecast/data_stream/ttp_url_logs/_dev/test/system/test-v1-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input: httpjson
service: mimecast
vars:
api_key: test
app_key: test
app_id: test
access_key: xxxx
secret_key: xxxx
Expand Down
2 changes: 2 additions & 0 deletions packages/sailpoint_identity_sc/data_stream/events/_dev/test/system/test-default-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ vars:
client_secret: eweqweqwqew
api_host: http://{{Hostname}}:{{Port}}
token_url: http://{{Hostname}}:{{Port}}/oauth/token

@github-actions github-actions Bot Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM Undefined variable 'token_url' may cause validation error

Why: The 'token_url' variable is not defined in the package manifest. With the stricter simplified Fleet API validation, undefined variables may cause errors. The token URL is hardcoded in the CEL template as '{{api_host}}/oauth/token', so this test config variable serves no purpose.

Suggested change
token_url: http://{{Hostname}}:{{Port}}/oauth/token
input: cel
service: sailpoint
vars:
api_version: v2025
client_id: qwerty
client_secret: eweqweqwqew
api_host: http://{{Hostname}}:{{Port}}
token_scopes:
- sp:scopes:all
data_stream:
vars:
limit: 2
tags:
- forwarded
assert:
hit_count: 3

Why is Claude responding? | Type @claude to interact further

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

token_scopes:
- sp:scopes:all
data_stream:
vars:
limit: 2
Expand Down
1 change: 1 addition & 0 deletions packages/ti_abusech/data_stream/ja3_fingerprints/_dev/test/system/test-default-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ data_stream:
url: http://{{Hostname}}:{{Port}}/blacklist/ja3_fingerprints.csv
preserve_original_event: true
vars:
auth_key: test_auth_key
enable_request_tracer: true
assert:
hit_count: 10
Expand Down
5 changes: 5 additions & 0 deletions packages/ti_opencti/data_stream/indicator/_dev/test/system/test-default-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
input: cel
service: opencti_stub
# The simplified Fleet API coerces string "false"/"true" to booleans before
# reaching the select-type validation, so "false" fails include() against the
# string options. Force the legacy API until Fleet fixes the schema ordering.
# See https://github.com/elastic/kibana/issues/255976
policy_api_format: legacy

@jsoriano jsoriano Mar 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for this added in elastic/package-spec#1103 and elastic/elastic-package#3307.

vars:
url: http://{{Hostname}}:{{Port}}
api_key: test_api_key
Expand Down