[cloud_security_posture] Remove dynamic: false from misconfiguration transform#17637
Conversation
…transform to allow ecs@mappings dynamic templates to evaluate
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
@maxcold is there any risk introduced by this change? AFAIK it makes it kinda schema-less and we might have conflicts where the same field has two different types and can be ingested to the same index. |
|
@alexreal1314 tbh I could think of a case when it will be a problem. Now we have |
|
@alexreal1314 I think your concerns are close to what was brought up in this comment #17552 (review) . But I'm not sure if keeping explicit transform mapping is worth it. |
|
Package cloud_security_posture - 3.3.0-preview08 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/3.3.0-preview08/ |
PR #17552 removed explicit ECS field definitions from CDR integration transform destinations, relying on the
ecs@mappingscomponent template. This broke ECS field searchability and Group-by in the Kibana CSP Findings data grid because the CSP misconfiguration transform haddynamic: false, which completely preventsecs@mappingsdynamic templates from evaluating.This PR removes
dynamic: falseand the redundantstrings_as_keyworddynamic template, keeping only the index sort settings anddate_detection: false.The
dynamic: falsesetting is also not inline with other CDR related transforms,cloud_security_postureintegration is the only integration with this settingFixes:
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
ecs@mappingsand nodynamic: false:Related issues
Fixes the regression introduced in #17552