Skip to content

Conversation

@ezzamo
Copy link
Contributor

@ezzamo ezzamo commented Jan 7, 2026

Proposed commit message

eset_protect: remove unsupported OAuth client_id/client_secret fields

WHAT

This PR updates the eset_protect integration OAuth configuration to align with the current ESET Connect API specification for /oauth/token.

  • Removes client.id and client.secret from the auth.oauth2 configuration in the CEL inputs.
  • Keeps the existing authentication flow intact (password grant to obtain tokens, and refresh token grant for renewal).

WHY

The ESET Connect API Swagger documentation for /oauth/token specifies the request body for supported grant types (password and refresh_token). In that specification, the request body parameters no longer includes client_id or client_secret as it is fully deprecated.

The integration currently includes client.id and client.secret fields (set to empty strings). These fields are no longer supported by the published specification and are therefore unnecessary. Keeping them in the integration configuration is misleading during troubleshooting (it suggests the API expects these client credentials).

References:

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices.

How to test this PR locally

From the integrations repo:

  • cd packages/eset_protect
  • elastic-package lint
  • elastic-package build

upload it through kibana

Related issues

  • N/A

@ezzamo ezzamo requested a review from a team as a code owner January 7, 2026 21:42
@andrewkroh andrewkroh added Integration:eset_protect ESET PROTECT Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 8, 2026
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chemamartinez
Copy link
Contributor

/test

@ezzamo ezzamo force-pushed the fix/eset-protect-oauth2 branch from afecda7 to b489545 Compare January 16, 2026 10:23
@ezzamo ezzamo requested a review from chemamartinez January 16, 2026 10:59
@chemamartinez
Copy link
Contributor

/test

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package eset_protect 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 1976.28 1406.47 -569.81 (-28.83%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@ezzamo ezzamo requested a review from chemamartinez January 16, 2026 13:57
@chemamartinez chemamartinez merged commit 316abf2 into elastic:main Jan 19, 2026
8 checks passed
@elastic-vault-github-plugin-prod

Package eset_protect - 1.12.0 containing this change is available at https://epr.elastic.co/package/eset_protect/1.12.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:eset_protect ESET PROTECT Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants