-
Notifications
You must be signed in to change notification settings - Fork 531
Eset protect oauth2 cleanup #16897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Eset protect oauth2 cleanup #16897
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
/test |
afecda7 to
b489545
Compare
chemamartinez
approved these changes
Jan 16, 2026
Contributor
|
/test |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
event |
1976.28 | 1406.47 | -569.81 (-28.83%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
|
chemamartinez
approved these changes
Jan 19, 2026
|
Package eset_protect - 1.12.0 containing this change is available at https://epr.elastic.co/package/eset_protect/1.12.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Integration:eset_protect
ESET PROTECT
Team:Security-Service Integrations
Security Service Integrations team [elastic/security-service-integrations]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
WHAT
This PR updates the eset_protect integration OAuth configuration to align with the current ESET Connect API specification for /oauth/token.
WHY
The ESET Connect API Swagger documentation for
/oauth/tokenspecifies the request body for supported grant types (password and refresh_token). In that specification, the request body parameters no longer includesclient_idorclient_secretas it is fully deprecated.The integration currently includes
client.idandclient.secretfields (set to empty strings). These fields are no longer supported by the published specification and are therefore unnecessary. Keeping them in the integration configuration is misleading during troubleshooting (it suggests the API expects these client credentials).References:
Checklist
How to test this PR locally
From the integrations repo:
cd packages/eset_protectelastic-package lintelastic-package buildupload it through kibana
Related issues