-
Notifications
You must be signed in to change notification settings - Fork 531
[WithSecure Elements] Add missing fields and documentation improvements #16715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| type: enhancement | ||
| - description: "Added ECP (Collaboration Protection) and XM (Exposure Management) to default engine groups configuration." | ||
| type: enhancement | ||
| link: "https://github.com/elastic/integrations/pull/16715" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this link field to the other changes items.
| - description: "Added missing fields from API specifications for security events and incidents." | ||
| type: enhancement | ||
| - description: "Updated README documentation with comprehensive field listing and improved setup instructions." | ||
| type: documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| type: documentation | |
| type: enhancement |
Documentation is not a valid type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation changes need to be added in _dev/build/docs/README.md, so this file docs/README.md is autogenerated when building the package with elastic-package build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't add these kind of screenshots into the package generally. The expected content of this img folder is dashboard screenshots.
Please remove all these screenshots, add them into the pull request description instead.
| - name: description | ||
| type: text | ||
| description: Detailed description of the event type | ||
| - name: server_timestamp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to add some test cases where we can see how events with these new fields are processed and stored.
Summary
This PR updates the WithSecure Elements integration to version 0.2.0 by adding missing fields from the API specifications and improving documentation.
Changes
Field Additions
readableIncidentId,mergedTosystemWide,readOnly,rebootRequiredToDelete,availableActions,recommendedAction,containerSize,containerMailbox,subItem,accessOperation,accessFlags,accessorHash,accessorPathtargetFileVersion,targetPrevalence,targetProductName,targetProductVersion,targetSignatureSignerName,targetVersionCompanyName,errorMessageitems,backupFolder,isQuarantineAllowed,processOperations,registryOperationscontentType,websiteUrl,computerNameruleGroupName,layerName,ruleDirection,ipProtocolrarity,exploit,commandLinedevicePath,deviceId,deviceName,initiatorprocessIdactionType,initiator_certificate_hash,initiator_signer_name,ipAddress,requestTypeoperation,processHash,processPath,processTeamIdserviceId,inboxRuleName,prevalenceScore,filename, and all ECP-specific fieldsrecommendationDetails,recommendationId,recommendationName,recommendationStatus,remediationEffort,remediationEffortString,remediationImpact,topAssets,totalAssets,topFindings,totalFindingsappName,contentNamedaysFromLastUpdateserver_timestampandxmRecommendationKeywinsAddress,winsName,clientTypedescriptionfieldConfiguration Updates
Documentation Improvements
Version Update
0.1.0to0.2.0