Skip to content

Conversation

@moxarth-rathod
Copy link
Contributor

Proposed commit message

box_events: remove non-ecs fields in ecs namespace

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/box_events directory.
  • Run the following command to run tests.

elastic-package test -v

Related issues

@moxarth-rathod moxarth-rathod self-assigned this Nov 12, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner November 12, 2025 08:09
@moxarth-rathod moxarth-rathod added Integration:box_events Box Events bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Nov 12, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@moxarth-rathod moxarth-rathod added breaking change and removed bugfix Pull request that fixes a bug issue labels Nov 12, 2025
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Nov 12, 2025
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't these values be move to actual ECS fields?

For example:

related.location.{lat,lon} --> geo.location.{lat,lon}

@moxarth-rathod
Copy link
Contributor Author

Can't these values be move to actual ECS fields?

For example:

related.location.{lat,lon} --> geo.location.{lat,lon}

@chrisberkhout they are already present under threat.enrichment, so i think moving them to ECS fields isn’t required.

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

@chrisberkhout
Copy link
Contributor

Can't these values be move to actual ECS fields?
For example:

related.location.{lat,lon} --> geo.location.{lat,lon}

@chrisberkhout they are already present under threat.enrichment, so i think moving them to ECS fields isn’t required.

Thanks!

@moxarth-rathod moxarth-rathod merged commit e73dd5a into elastic:main Nov 19, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package box_events - 3.0.0 containing this change is available at https://epr.elastic.co/package/box_events/3.0.0/

tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
box_events: remove non-ecs fields in ecs namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:box_events Box Events Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

box_events: take care of non-ECS fields in ECS namespace

4 participants