Skip to content

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented Jun 11, 2025

Proposed commit message

This commit adds a message at the beginning of the Custom Logs (Filestream) integration warning that only files >= 1024 bytes in size will be ingested and pointing to the documentation to change this behaviour.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • ~~I have verified that any added dashboard complies with Kibana's Dashboard good practices ~~

## Author's Checklist

How to test this PR locally

Build the package
Deploy the package
Look at the documentation

## Related issues

Screenshots

2025-06-11_10-37

@belimawr belimawr self-assigned this Jun 11, 2025
@belimawr belimawr added enhancement New feature or request Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels Jun 11, 2025
@belimawr belimawr marked this pull request as ready for review June 11, 2025 14:01
@belimawr belimawr requested a review from a team as a code owner June 11, 2025 14:01
@belimawr belimawr requested review from mauri870 and rdner June 11, 2025 14:01
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Member

@belimawr Do you mind also fixing the formatting for bold text while at it? For bold to work there should be no spaces after or before **.

For example today it looks like this in multiple places:

image

I was about to open a separate PR but it seems simple enough that you can fix it here.

@belimawr
Copy link
Contributor Author

Thanks for spotting that @mauri870! They're fixed now.

@belimawr belimawr enabled auto-merge (squash) June 11, 2025 15:56
@belimawr
Copy link
Contributor Author

I've enabled auto-merge

@andrewkroh andrewkroh added the Integration:filestream Custom Logs (Filestream) label Jun 11, 2025
@belimawr belimawr merged commit ef8fe23 into elastic:main Jun 11, 2025
5 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @belimawr

@elastic-sonarqube
Copy link

@elastic-vault-github-plugin-prod

Package filestream - 1.1.4 containing this change is available at https://epr.elastic.co/package/filestream/1.1.4/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:filestream Custom Logs (Filestream) Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants