[CI] Add dev/codeowners and .go-version file to be synced in backport branches#13994
Merged
mrodm merged 6 commits intoelastic:mainfrom May 26, 2025
Merged
[CI] Add dev/codeowners and .go-version file to be synced in backport branches#13994mrodm merged 6 commits intoelastic:mainfrom
mrodm merged 6 commits intoelastic:mainfrom
Conversation
mrodm
commented
May 26, 2025
Comment on lines
+105
to
+107
| currentPackage=$(basename "${dir}") | ||
| echo "Removing ${currentPackage} from .github/CODEOWNERS" | ||
| sed -i "/^\/packages\/${currentPackage}\//d" .github/CODEOWNERS |
Collaborator
Author
There was a problem hiding this comment.
Leave just in .github/CODEOWNERS the entries related to ${PACKAGE_NAME} package.
mrodm
commented
May 26, 2025
Comment on lines
+161
to
+163
| echo "Copying $CODEOWNERS_SCRIPTS_FOLDER from $SOURCE_BRANCH..." | ||
| git checkout "$SOURCE_BRANCH" -- "${CODEOWNERS_SCRIPTS_FOLDER}" | ||
| git add ${CODEOWNERS_SCRIPTS_FOLDER} |
Collaborator
Author
There was a problem hiding this comment.
New folder added dev/codeowners
mrodm
commented
May 26, 2025
Comment on lines
+172
to
+174
| echo "Copying .go-version from $SOURCE_BRANCH..." | ||
| git checkout "$SOURCE_BRANCH" -- ".go-version" | ||
| git add .go-version |
Collaborator
Author
There was a problem hiding this comment.
New file added: .go-version
As this script is run with the contents of main branch, go.mod file in the backport branch is updated using the Golang version (.go-version) defined in main branch.
This ensures that backport branch is run with the same Golang version.
Tested that elastic-package v0.100.0 version worked with a newer Golang version in this build: #13991
|
jsoriano
approved these changes
May 26, 2025
anupratharamachandran
pushed a commit
to anupratharamachandran/integrations
that referenced
this pull request
Jun 2, 2025
… branches (elastic#13994) Sync in backport branches dev/codeowners folder, .go-version file and update .github/CODEOWNERS file to avoid failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR updates the script in charge of creating backport branches:
dev/codeownersfolder to be synced in backport script too..go-versionfile to be synced in backport script too.go mod tidyfrommainbranch,go.modfile in the backport branch is updated taking into account that Golang version..github/CODEOWNERSfile removing the paths of other packages ifREMOVE_OTHER_PACKAGESvariable is set to true.Example backport buildkite build: https://buildkite.com/elastic/integrations-backport/builds/179#0196ff67-5173-426d-bf19-63f000a6921d
These changes creating a backport branch have been tested in this integrations PR: #13991
Related issues