Skip to content

[ti_anomali] Modify field type to eliminate field conflicts within the data streams.#13909

Merged
brijesh-elastic merged 6 commits intoelastic:mainfrom
brijesh-elastic:ti_anomali-2.0.0
Jun 11, 2025
Merged

[ti_anomali] Modify field type to eliminate field conflicts within the data streams.#13909
brijesh-elastic merged 6 commits intoelastic:mainfrom
brijesh-elastic:ti_anomali-2.0.0

Conversation

@brijesh-elastic
Copy link
Copy Markdown
Collaborator

Proposed commit message

ti_anomali: resolve field data type conflicts between data streams

This introduces a breaking change by altering the field type from 'long' to
'keyword' for the 'import_session_id', 'trusted_circle_ids', and 'update_id' fields,
and from 'short' to 'long' for the 'confidence' field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/ti_anomali directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@brijesh-elastic brijesh-elastic self-assigned this May 14, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner May 14, 2025 10:02
@brijesh-elastic brijesh-elastic added Integration:ti_anomali Anomali ThreatStream bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels May 14, 2025
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented May 14, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@brijesh-elastic brijesh-elastic requested a review from efd6 May 15, 2025 06:21
Type of indicator—domain, email, ip, md5, string, url.
- name: update_id
type: long
type: keyword
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During integration upgrade, the source data stream-backed indices are rolled over, which doesn't cause conflicts during indexing.
But the destination indices aren't data stream backed, hence they wouldn't roll over. This will cause indexing failures because of mapping conflicts. You will also need to update transform's destination index suffix, and also fleet_transform_version to actually update the transform.

Please also test the upgrade process.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried upgrading the integration without changing destination index and fleet_transform_version and noticed that the destination index mapping has changed and newer documents ingested without any error. However, the newer documents still indexed with the previous field type, which is unusual. After changing the destination index name and fleet_transform_version it ingested documents with modified field types.

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @brijesh-elastic

@elastic-sonarqube
Copy link
Copy Markdown

@brijesh-elastic brijesh-elastic merged commit 3330e46 into elastic:main Jun 11, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package ti_anomali - 2.0.0 containing this change is available at https://epr.elastic.co/package/ti_anomali/2.0.0/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:ti_anomali Anomali ThreatStream Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ti_anomali] Field data type conflicts between data streams

6 participants