Skip to content

Conversation

@ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 10, 2025

Proposed commit message

This PR removes the agent.name filter with the hardcoded value 9ca5ae305860 from the Agent Metrics dashboard. Currently, with this filter present, no metrics are displayed:

Screenshot 2025-04-10 at 11 42 56

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

@ycombinator ycombinator added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:elastic_agent Elastic Agent bugfix Pull request that fixes a bug issue labels Apr 10, 2025
@ycombinator ycombinator requested a review from a team as a code owner April 10, 2025 18:45
@ycombinator ycombinator changed the title [Elastic Agent] Remove harcoded agent.name filter [Elastic Agent] Remove hardcoded agent.name filter from Agent Metrics dashboard Apr 10, 2025
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashboard change LGTM, linter should be complaining about the changelog / manifest version mismatch and the link formatting.

changes:
- description: Remove hardcoded agent.name filter
type: bugfix
link: "TODO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link needs updating, and so will the manifest.yml to point to new version.

@ycombinator ycombinator requested a review from leehinman April 10, 2025 18:59
@ycombinator ycombinator enabled auto-merge (squash) April 10, 2025 19:00
@ycombinator ycombinator merged commit 2e6da2a into elastic:main Apr 10, 2025
5 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube
Copy link

@ycombinator ycombinator deleted the bugfix-elastic_agent-remove-dashboard-filter branch April 10, 2025 19:36
@elastic-vault-github-plugin-prod

Package elastic_agent - 2.2.1 containing this change is available at https://epr.elastic.co/package/elastic_agent/2.2.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:elastic_agent Elastic Agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants