Skip to content

[CI] Remove workaround test stack 9 packages in daily CI jobs#13491

Merged
mrodm merged 7 commits intoelastic:mainfrom
mrodm:remove-workaround-test-stack-9-packages
Apr 11, 2025
Merged

[CI] Remove workaround test stack 9 packages in daily CI jobs#13491
mrodm merged 7 commits intoelastic:mainfrom
mrodm:remove-workaround-test-stack-9-packages

Conversation

@mrodm
Copy link
Collaborator

@mrodm mrodm commented Apr 10, 2025 •
edited
Loading

Proposed commit message

This PR removes the workaround to test packages using Elastic stack with version 9.x if packages were just supporting up to ^8.x.y introduced in #11138.

At the moment of creating this PR, there are 330 packages in this repository. Applying this filter, 317 packages are tested. The ones that are filtered out are:

  • bluecoat: ^7.14.1 || ^8.8.0
  • cloud_asset_inventory: >=8.18.0
    • This should not be skipped, CI scripts need to be reviewed.
  • cloud_defend: ^8.11.0
  • enterprisesearch: ^8.7.0
  • fortinet_forticlient: ^8.8.0
  • juniper_junos: ^8.8.0
  • juniper_netscreen: ^8.8.0
  • netscout: ^8.8.0
  • platform_observability: ^8.3.0
  • radware: ^8.8.0
  • synthetics_dashboards: ^8.10.1
  • tenable_ot_security: ^8.16.1
  • tencent_cloud: ^8.16.0

In order to handler correctly the Kibana constraint >=8.18.0, the code in charge of validating those constraints given a STACK_VERSION has been replaced by mage targets running all that logic in Golang.

Author's Checklist

Related issues

@mrodm mrodm self-assigned this Apr 10, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Apr 10, 2025 •
edited
Loading

🚀 Benchmarks report

Package apache 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 4464.29 2976.19 -1488.1 (-33.33%) 💔

Package apache_tomcat 👍(6) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
thread_pool 9900.99 6250 -3650.99 (-36.87%) 💔

Package atlassian_jira 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2590.67 2197.8 -392.87 (-15.16%) 💔

Package auth0 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
logs 4201.68 1795.33 -2406.35 (-57.27%) 💔

Package aws 👍(8) 💚(2) 💔(9)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
guardduty 987.17 789.27 -197.9 (-20.05%) 💔
inspector 1934.24 1324.5 -609.74 (-31.52%) 💔
rds 18518.52 15625 -2893.52 (-15.63%) 💔
route53_public_logs 19607.84 13157.89 -6449.95 (-32.89%) 💔
securityhub_findings 1410.44 1138.95 -271.49 (-19.25%) 💔
cloudtrail 2192.98 1754.39 -438.59 (-20%) 💔
elb_logs 5347.59 4255.32 -1092.27 (-20.43%) 💔
emr_logs 16949.15 10638.3 -6310.85 (-37.23%) 💔
firewall_logs 2544.53 2150.54 -393.99 (-15.48%) 💔

Package aws_bedrock 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
invocation 1259.45 1062.7 -196.75 (-15.62%) 💔

Package aws_mq 👍(0) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
activemq_audit_logs 4329 3546.1 -782.9 (-18.09%) 💔
rabbitmq_general_logs 13333.33 10869.57 -2463.76 (-18.48%) 💔

Package awsfirehose 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
logs 3676.47 2053.39 -1623.08 (-44.15%) 💔

Package azure 👍(5) 💚(3) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
application_gateway 2577.32 2040.82 -536.5 (-20.82%) 💔
auditlogs 2564.1 2109.7 -454.4 (-17.72%) 💔
eventhub 500000 333333.33 -166666.67 (-33.33%) 💔

Package azure_metrics 👍(1) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
compute_vm_scaleset 200000 142857.14 -57142.86 (-28.57%) 💔
container_service 250000 200000 -50000 (-20%) 💔

Package azure_openai 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
metrics 333333.33 166666.67 -166666.66 (-50%) 💔

Package barracuda 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
waf 777.6 550.66 -226.94 (-29.18%) 💔

Package bitwarden 👍(0) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
group 20000 11235.96 -8764.04 (-43.82%) 💔
member 10000 7194.24 -2805.76 (-28.06%) 💔
policy 7142.86 5376.34 -1766.52 (-24.73%) 💔

Package carbon_black_cloud 👍(3) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset_vulnerability_summary 11627.91 8547.01 -3080.9 (-26.5%) 💔

Package ceph 👍(3) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
osd_performance 25641.03 20408.16 -5232.87 (-20.41%) 💔

Package cisco_duo 👍(5) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
activity 3623.19 2673.8 -949.39 (-26.2%) 💔
telephony_v2 21276.6 16129.03 -5147.57 (-24.19%) 💔

Package cisco_ios 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2283.11 1733.1 -550.01 (-24.09%) 💔

Package cisco_meraki_metrics 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
device_health 45454.55 38461.54 -6993.01 (-15.38%) 💔

Package citrix_adc 👍(1) 💚(3) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
service 13157.89 10309.28 -2848.61 (-21.65%) 💔
vpn 6666.67 5291.01 -1375.66 (-20.63%) 💔

Package citrix_waf 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1709.4 1420.45 -288.95 (-16.9%) 💔

Package claroty_ctd 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
baseline 3105.59 1949.32 -1156.27 (-37.23%) 💔

Package cloud_security_posture 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
vulnerabilities 250000 166666.67 -83333.33 (-33.33%) 💔

Package cloudflare_logpush 👍(9) 💚(4) 💔(8)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
nel_report 29411.76 24390.24 -5021.52 (-17.07%) 💔
page_shield_events 18867.92 13333.33 -5534.59 (-29.33%) 💔
access_request 4115.23 3344.48 -770.75 (-18.73%) 💔
spectrum_event 3773.58 3164.56 -609.02 (-16.14%) 💔
workers_trace 8771.93 7092.2 -1679.73 (-19.15%) 💔
casb 9523.81 6896.55 -2627.26 (-27.59%) 💔
email_security_alerts 2652.52 2252.25 -400.27 (-15.09%) 💔
firewall_event 4444.44 3355.7 -1088.74 (-24.5%) 💔

Package cyberark_epm 👍(4) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
raw_event 2000 1626.02 -373.98 (-18.7%) 💔

Package elasticsearch 👍(2) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2217.29 1615.51 -601.78 (-27.14%) 💔

Package forgerock 👍(5) 💚(2) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
idm_core 45454.55 38461.54 -6993.01 (-15.38%) 💔
am_config 18518.52 15151.52 -3367 (-18.18%) 💔
am_core 8333.33 5000 -3333.33 (-40%) 💔
idm_activity 24390.24 17857.14 -6533.1 (-26.79%) 💔

Package fortinet_fortiedr 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 582.07 459.56 -122.51 (-21.05%) 💔

Package golang 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
expvar 3690.04 2645.5 -1044.54 (-28.31%) 💔

Package google_scc 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 3115.26 2493.77 -621.49 (-19.95%) 💔

Package google_workspace 👍(8) 💚(1) 💔(8)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
login 10869.57 8264.46 -2605.11 (-23.97%) 💔
rules 4184.1 3460.21 -723.89 (-17.3%) 💔
saml 10101.01 3039.51 -7061.5 (-69.91%) 💔
token 1814.88 1506.02 -308.86 (-17.02%) 💔
alert 3968.25 2873.56 -1094.69 (-27.59%) 💔
calendar 4975.12 3401.36 -1573.76 (-31.63%) 💔
context_aware_access 6369.43 4672.9 -1696.53 (-26.64%) 💔
data_studio 6289.31 4901.96 -1387.35 (-22.06%) 💔

Package hadoop 👍(2) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
datanode 12820.51 9433.96 -3386.55 (-26.42%) 💔
node_manager 22727.27 18181.82 -4545.45 (-20%) 💔

Package hashicorp_vault 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 3278.69 1980.2 -1298.49 (-39.6%) 💔
log 9803.92 6849.32 -2954.6 (-30.14%) 💔

Package ibmmq 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
qmgr 3460.21 2525.25 -934.96 (-27.02%) 💔

Package iis 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 2222.22 1579.78 -642.44 (-28.91%) 💔
error 3508.77 2403.85 -1104.92 (-31.49%) 💔

Package infoblox_bloxone_ddi 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
dns_data 2597.4 2057.61 -539.79 (-20.78%) 💔

Package jamf_pro 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
inventory 4950.5 3831.42 -1119.08 (-22.61%) 💔

Package jamf_protect 👍(1) 💚(1) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 1602.56 1349.53 -253.03 (-15.79%) 💔
telemetry 1133.79 954.2 -179.59 (-15.84%) 💔
telemetry_legacy 1841.62 1557.63 -283.99 (-15.42%) 💔

Package juniper_junos 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 83333.33 62500 -20833.33 (-25%) 💔

Package logstash 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
slowlog 4329 3448.28 -880.72 (-20.34%) 💔

Package microsoft_dnsserver 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
analytical 3367 2232.14 -1134.86 (-33.71%) 💔

Package microsoft_exchange_server 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
imap4_pop3 17857.14 15151.52 -2705.62 (-15.15%) 💔

Package microsoft_sentinel 👍(0) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 2865.33 1470.59 -1394.74 (-48.68%) 💔
incident 3773.58 3048.78 -724.8 (-19.21%) 💔

Package microsoft_sqlserver 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 8849.56 6849.32 -2000.24 (-22.6%) 💔

Package mimecast 👍(6) 💚(3) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
dlp_logs 13333.33 10416.67 -2916.66 (-21.87%) 💔
ttp_ap_logs 8196.72 4878.05 -3318.67 (-40.49%) 💔

Package mongodb_atlas 👍(4) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
project 3257.33 2232.14 -1025.19 (-31.47%) 💔

Package mysql 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
slowlog 31250 22727.27 -8522.73 (-27.27%) 💔

Package nagios_xi 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 19230.77 8771.93 -10458.84 (-54.39%) 💔

Package netflow 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 11363.64 8333.33 -3030.31 (-26.67%) 💔

Package netskope 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 1545.6 1002 -543.6 (-35.17%) 💔
events 2079 1745.2 -333.8 (-16.06%) 💔

Package o365_metrics 👍(8) 💚(8) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
service_health 71428.57 50000 -21428.57 (-30%) 💔
sharepoint_site_usage_storage 20833.33 13157.89 -7675.44 (-36.84%) 💔
viva_engage_groups_activity_group_detail 6756.76 5494.51 -1262.25 (-18.68%) 💔
onedrive_usage_account_detail 4761.9 3623.19 -1138.71 (-23.91%) 💔
onedrive_usage_file_counts 15384.62 12195.12 -3189.5 (-20.73%) 💔

Package opencanary 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 3076.92 2188.18 -888.74 (-28.88%) 💔

Package oracle_weblogic 👍(1) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
managed_server 27027.03 7874.02 -19153.01 (-70.87%) 💔

Package proofpoint_on_demand 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
mail 5102.04 3257.33 -1844.71 (-36.16%) 💔
message 1612.9 1153.4 -459.5 (-28.49%) 💔

Package proofpoint_tap 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
clicks_blocked 3030.3 2531.65 -498.65 (-16.46%) 💔

Package qualys_vmdr 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
user_activity 12195.12 9345.79 -2849.33 (-23.36%) 💔

Package rubrik 👍(4) 💚(4) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
tasks 43478.26 25000 -18478.26 (-42.5%) 💔
unmanaged_objects 27027.03 16129.03 -10898 (-40.32%) 💔
node_statistics 16129.03 12820.51 -3308.52 (-20.51%) 💔
physical_hosts 37037.04 27777.78 -9259.26 (-25%) 💔

Package sophos_central 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 1269.04 902.53 -366.51 (-28.88%) 💔

Package spycloud 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
breach_catalog 1160.09 980.39 -179.7 (-15.49%) 💔
breach_record 2590.67 1207.73 -1382.94 (-53.38%) 💔

Package squid 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 5376.34 3533.57 -1842.77 (-34.28%) 💔

Package stormshield 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2092.05 1733.1 -358.95 (-17.16%) 💔

Package sysdig 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 3703.7 2881.84 -821.86 (-22.19%) 💔

Package system 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
security 2659.57 1919.39 -740.18 (-27.83%) 💔

Package tanium 👍(3) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
endpoint_config 10989.01 7575.76 -3413.25 (-31.06%) 💔

Package teleport 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 548.55 436.49 -112.06 (-20.43%) 💔

Package tenable_io 👍(2) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset 1890.36 1470.59 -419.77 (-22.21%) 💔
scan 19230.77 12658.23 -6572.54 (-34.18%) 💔

Package tenable_sc 👍(0) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset 3401.36 2557.54 -843.82 (-24.81%) 💔
plugin 1776.2 1086.96 -689.24 (-38.8%) 💔
vulnerability 1584.79 687.29 -897.5 (-56.63%) 💔

Package tencent_cloud 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 3460.21 2770.08 -690.13 (-19.94%) 💔

Package ti_abusech 👍(1) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threatfox 4347.83 3690.04 -657.79 (-15.13%) 💔

Package ti_custom 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
indicator 2083.33 1118.57 -964.76 (-46.31%) 💔

Package ti_eclecticiq 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat 2873.56 2380.95 -492.61 (-17.14%) 💔

Package ti_eset 👍(3) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
apt 1724.14 1212.12 -512.02 (-29.7%) 💔
cc 9708.74 6289.31 -3419.43 (-35.22%) 💔
domains 11111.11 6756.76 -4354.35 (-39.19%) 💔
url 15151.52 9345.79 -5805.73 (-38.32%) 💔

Package ti_misp 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat 2849 1808.32 -1040.68 (-36.53%) 💔
threat_attributes 2865.33 2257.34 -607.99 (-21.22%) 💔

Package ti_otx 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
pulses_subscribed 3095.98 2314.81 -781.17 (-25.23%) 💔
threat 10752.69 5434.78 -5317.91 (-49.46%) 💔

Package ti_rapid7_threat_command 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 2840.91 2192.98 -647.93 (-22.81%) 💔

Package tines 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
time_saved 45454.55 11235.96 -34218.59 (-75.28%) 💔

Package tomcat 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 71428.57 47619.05 -23809.52 (-33.33%) 💔

Package trellix_epo_cloud 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 1661.13 1408.45 -252.68 (-15.21%) 💔

Package tychon 👍(14) 💚(4) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cve 1592.36 1353.18 -239.18 (-15.02%) 💔

Package vsphere 👍(6) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
datastorecluster 50000 38461.54 -11538.46 (-23.08%) 💔

Package websphere_application_server 👍(3) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
servlet 29411.76 19230.77 -10180.99 (-34.62%) 💔

Package windows 👍(4) 💚(3) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
applocker_exe_and_dll 6451.61 4115.23 -2336.38 (-36.21%) 💔
applocker_packaged_app_execution 12195.12 8130.08 -4065.04 (-33.33%) 💔

Package wiz 👍(2) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cloud_configuration_finding 6024.1 2994.01 -3030.09 (-50.3%) 💔
vulnerability 3236.25 1956.95 -1279.3 (-39.53%) 💔

Package zeek 👍(25) 💚(13) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
capture_loss 11764.71 8474.58 -3290.13 (-27.97%) 💔
signature 50000 38461.54 -11538.46 (-23.08%) 💔
dce_rpc 14705.88 11235.96 -3469.92 (-23.6%) 💔
dhcp 21739.13 15384.62 -6354.51 (-29.23%) 💔
dnp3 20000 15625 -4375 (-21.88%) 💔

Package zscaler_zia 👍(5) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 3424.66 2610.97 -813.69 (-23.76%) 💔
tunnel 5181.35 4366.81 -814.54 (-15.72%) 💔

Package zscaler_zpa 👍(3) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
browser_access 1972.39 1453.49 -518.9 (-26.31%) 💔

To see the full report comment with /test benchmark fullreport

@mrodm mrodm force-pushed the remove-workaround-test-stack-9-packages branch from 842b6ac to 053d0d3 Compare April 10, 2025 10:42
@mrodm mrodm marked this pull request as ready for review April 10, 2025 19:17
@mrodm mrodm requested a review from a team as a code owner April 10, 2025 19:17
mrodm
mrodm commented Apr 10, 2025
View reviewed changes
.buildkite/scripts/common.sh
Comment on lines -474 to -476
# TODO: Allowed temporarily to test packages with stack version 9.0 if they have as constraint ^8.0 defined too.
# This workaround should be removed once packages have been updated their constraints for 9.0 stack.
if [[ ( ! ( "${kibana_version}" =~ \^9\. || "${kibana_version}" =~ \^8\. ) ) && "${STACK_VERSION}" =~ ^9\. ]]; then
Copy link
Collaborator Author

@mrodm mrodm Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there are already 317 packages out of 330 packages (at the moment of creating this PR), it looks like this workaround could be removed.

The packages that would not be tested in the daily jobs for 9.1.0-SNAPSHOT are listed in the PR description.

WDYT @elastic/ecosystem ?

Copy link
Collaborator Author

@mrodm mrodm Apr 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem of applying this PR now is there are some packages that had failed tests in 9.1.0-SNAPSHOT:

If we merge this PR, should we close those issues ?

juniper_junos and juniper_network are deprecated and they have some comments that they are not going to be fixed, so I think they could be closed.

So what should we do with the enteprisesearch issues if this PR is merged?

Copy link
Member

@jsoriano jsoriano Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this PR, should we close those issues ?

Yes, maybe these packages are not intended to ever work in 9.x.

So what should we do with the enteprisesearch issues if this PR is merged?

@elastic/stack-monitoring is the enterprisesearch package intended to be supported in 9.x? Its constraints haven't been updated.

Copy link
Contributor

@consulthys consulthys Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoriano Due to the Enterprise Search deprecation, it won't be available in Stack 9, which is why the constraints haven't been updated, i.e. there won't be an Enterprise Search 9 server to monitor

Copy link
Member

@jsoriano jsoriano Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's right, you already mentioned it in an internal comment. Thanks for the confirmation!

Copy link
Collaborator Author

@mrodm mrodm Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, so then I think those related issues can be closed after merging this PR.
Thanks!

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Apr 10, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

elasticmachine commented Apr 10, 2025

💚 Build Succeeded

History

cc @mrodm

jsoriano
jsoriano approved these changes Apr 11, 2025
View reviewed changes
.buildkite/scripts/common.sh
Comment on lines -474 to -476
# TODO: Allowed temporarily to test packages with stack version 9.0 if they have as constraint ^8.0 defined too.
# This workaround should be removed once packages have been updated their constraints for 9.0 stack.
if [[ ( ! ( "${kibana_version}" =~ \^9\. || "${kibana_version}" =~ \^8\. ) ) && "${STACK_VERSION}" =~ ^9\. ]]; then
Copy link
Member

@jsoriano jsoriano Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this PR, should we close those issues ?

Yes, maybe these packages are not intended to ever work in 9.x.

So what should we do with the enteprisesearch issues if this PR is merged?

@elastic/stack-monitoring is the enterprisesearch package intended to be supported in 9.x? Its constraints haven't been updated.

@mrodm mrodm mentioned this pull request Apr 11, 2025
Merged
@mrodm mrodm merged commit 6b59572 into elastic:main Apr 11, 2025
7 checks passed
@mrodm mrodm deleted the remove-workaround-test-stack-9-packages branch April 11, 2025 11:02
This was referenced Apr 11, 2025
Closed
Closed
Closed
Closed
Closed
@mrodm mrodm mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@consulthys consulthys consulthys left review comments

Assignees

@mrodm mrodm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrodm @elasticmachine @jsoriano @consulthys