Skip to content

[CI] Create several schedules#13484

Merged
mrodm merged 5 commits intoelastic:mainfrom
mrodm:update-daily-job
Apr 10, 2025
Merged

[CI] Create several schedules#13484
mrodm merged 5 commits intoelastic:mainfrom
mrodm:update-daily-job

Conversation

@mrodm
Copy link
Collaborator

@mrodm mrodm commented Apr 9, 2025

Proposed commit message

This PR adds more schedules to the daily CI job. This will help to split the load in different builds.

Example of build testing packages with 7.x stack:
https://buildkite.com/elastic/integrations-schedule-daily/builds/539

Author's Checklist

Related issues

mrodm added a commit to mrodm/integrations that referenced this pull request Apr 9, 2025
mrodm added a commit to mrodm/integrations that referenced this pull request Apr 9, 2025
Daily step is going to be added as part of elastic#13484
@mrodm mrodm self-assigned this Apr 9, 2025
@elasticmachine
Copy link

elasticmachine commented Apr 9, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @mrodm

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mrodm mrodm marked this pull request as ready for review April 9, 2025 15:09
@mrodm mrodm requested a review from a team as a code owner April 9, 2025 15:09
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Selecting steps through environment variables looks a bit fragile, but seems easy to redistribute the steps executed on each schedule.

Comment on lines +28 to +29
if: |
build.env('TEST_PACKAGES_7_BRANCH') == "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have multiple pipelines instead of these conditions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that it could be easier to just manage one buildkite pipeline with all the steps and select the steps required in each build using environment variables. That would avoid creating several new Buildkite jobs.

It could be tested like this, if there are any issues we could create new Buildkite pipelines later.

env:
TEST_PACKAGES_7_BRANCH: "true"
TEST_PACKAGES_SERVERLESS: "true"
REPUBLISH_PACKAGES: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, allowing to select steps this way also looks good.

@mrodm mrodm merged commit 856f33b into elastic:main Apr 10, 2025
7 checks passed
@mrodm mrodm deleted the update-daily-job branch April 10, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants