Skip to content

Workaround issue with missing dynamic mapping in tines package#12082

Merged
jsoriano merged 0 commit intoelastic:mainfrom
jsoriano:workaround-tines-dynamic-mappings
Dec 16, 2024
Merged

Workaround issue with missing dynamic mapping in tines package#12082
jsoriano merged 0 commit intoelastic:mainfrom
jsoriano:workaround-tines-dynamic-mappings

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Dec 12, 2024

Proposed commit message

No dynamic mapping was being generated for
tines.audit_log.inputs.inputs.options.*, and this package uses the
tines.audit_log.inputs.inputs.options field directly, without having any
mapping for it or its sub-properties.

The workaround ensures that there is a mapping for
tines.audit_log.inputs.inputs.* that serves for
tines.audit_log.inputs.inputs.options as well as for its subobjects.

The configured dynamic mapping was not being generated due to some issue in
Fleet that we are investigating.

We detected this issue while refactoring field mappings tests in
elastic-package, more about this in elastic/elastic-package#2214[1].

[1]elastic/elastic-package#2214 (comment)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Install the package.
  • Check that logs-tines.audit_logs@package component template includes a dynamic mapping for these fields.

Related issues

@jsoriano jsoriano self-assigned this Dec 12, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:tines Tines (Community supported) labels Dec 12, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@jsoriano jsoriano marked this pull request as ready for review December 12, 2024 17:09
@jsoriano jsoriano requested a review from a team as a code owner December 12, 2024 17:09
@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Dec 12, 2024
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@jsoriano
Copy link
Copy Markdown
Member Author

Fix in kibana: elastic/kibana#204104

Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Also, please update the commit message body to work with non-markdown.

No dynamic mapping was being generated for
tines.audit_log.inputs.inputs.options.*, and this package uses the
tines.audit_log.inputs.inputs.options field directly, without having any
mapping for it or its sub-properties.

The workaround ensures that there is a mapping for
tines.audit_log.inputs.inputs.* that serves for
tines.audit_log.inputs.inputs.options as well as for its subobjects.

The configured dynamic mapping was not being generated due to some issue in
Fleet that we are investigating.

We detected this issue while refactoring field mappings tests in
elastic-package, more about this in elastic/elastic-package#2214[1].

[1]https://github.com/elastic/elastic-package/pull/2214#issuecomment-2536692641

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #19479 succeeded 94e4f97272c9cf10249247ecabc8785d27f17726
  • 💚 Build #19420 succeeded 2bf249c06bf4db0b7774c9cc4ac262f607d26ad2

cc @jsoriano

@elastic-sonarqube
Copy link
Copy Markdown

@jsoriano jsoriano merged commit 22c30d9 into elastic:main Dec 16, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package tines - 1.14.1 containing this change is available at https://epr.elastic.co/package/tines/1.14.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…ic#12082)

No dynamic mapping was being generated for
tines.audit_log.inputs.inputs.options.*, and this package uses the
tines.audit_log.inputs.inputs.options field directly, without having any
mapping for it or its sub-properties.

The workaround ensures that there is a mapping for
tines.audit_log.inputs.inputs.* that serves for
tines.audit_log.inputs.inputs.options as well as for its subobjects.

The configured dynamic mapping was not being generated due to some issue in
Fleet that we are investigating.

We detected this issue while refactoring field mappings tests in
elastic-package, more about this in elastic/elastic-package#2214[1].

[1]elastic/elastic-package#2214 (comment)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…ic#12082)

No dynamic mapping was being generated for
tines.audit_log.inputs.inputs.options.*, and this package uses the
tines.audit_log.inputs.inputs.options field directly, without having any
mapping for it or its sub-properties.

The workaround ensures that there is a mapping for
tines.audit_log.inputs.inputs.* that serves for
tines.audit_log.inputs.inputs.options as well as for its subobjects.

The configured dynamic mapping was not being generated due to some issue in
Fleet that we are investigating.

We detected this issue while refactoring field mappings tests in
elastic-package, more about this in elastic/elastic-package#2214[1].

[1]elastic/elastic-package#2214 (comment)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@jsoriano jsoriano deleted the workaround-tines-dynamic-mappings branch February 6, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:tines Tines (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants