Add aws.metrics_names_fingerprint field and mark it as a dimension#11366
Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom Oct 14, 2024
Merged
Add aws.metrics_names_fingerprint field and mark it as a dimension#11366kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng merged 2 commits intoelastic:mainfrom
Conversation
kaiyan-sheng
added
the
Team:obs-ds-hosted-services
andrewkroh
added
Integration:aws
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
|
axw
approved these changes
Oct 9, 2024
kcreddy
approved these changes
Oct 11, 2024
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…lastic#11366) Add aws.metrics_names_fingerprint field and mark it as a dimension in main branch
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…lastic#11366) Add aws.metrics_names_fingerprint field and mark it as a dimension in main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR adds aws.metrics_names_fingerprint which is a hash of the list of metric names exist in each document. For metrics coming in from Firehose, there can be cases two documents have the same timestamp, dimension, namespace, accountID, exportARN and region BUT from two different requests. With adding the aws.metrics_names_fingerprint as TSDB dimension, we are able to ingest these two documents into ES.
Checklist
changelog.ymlfile.Related issues
This PR is to add the change from #11281 into main branch.