-
Notifications
You must be signed in to change notification settings - Fork 562
[vSphere][datastore] Add support for additional metrics #10911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lucian-ioan
merged 30 commits into
elastic:main
from
lucian-ioan:update_vsphere_datastore_integration
Sep 19, 2024
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2004252
update event
lucian-ioan a2c2591
update fields.yml
lucian-ioan d81254b
add changelog entry
lucian-ioan e9147ab
update sample event
lucian-ioan 2eb74a8
elastic-package build
lucian-ioan 11a135b
fix sample event
lucian-ioan 8ce790b
fix vsphere name and fstype
lucian-ioan 321a5e2
follow changelog guidelines
0cbd1bc
update fields
0677108
better field descriptions
3b98122
update sample event
38b42aa
package build
2cb93db
add metric types
9f6b19f
revert dockerfile
73366a7
add dockerfile newline
6a47c43
add period
lucian-ioan 57aad0b
add triggered alarms
lucian-ioan 4c5186f
Merge branch 'main' into update_vsphere_datastore_integration
lucian-ioan 4c457aa
add disk capacity fields
lucian-ioan 7bb821b
add metric types
lucian-ioan 7cad138
update tag
lucian-ioan 5333a11
update version to 1.15.0-next
lucian-ioan 73a1b47
update kibana version to 8.15.2
lucian-ioan 4afc186
remove global period
lucian-ioan ac62604
remove latency and iops fields
lucian-ioan 9c7ae05
update triggered alarms to group
lucian-ioan 1bdac8d
add tags in stream.yml.hbs
lucian-ioan 47317a7
add system tests
lucian-ioan 0b87f5b
Merge remote-tracking branch 'origin' into update_vsphere_datastore_i…
lucian-ioan 9c15224
update readme
lucian-ioan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
packages/vsphere/data_stream/datastore/_dev/test/pipeline/test-datastore.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "events": [ | ||
| { | ||
| "vsphere": { | ||
| "datastore": { | ||
| "disk": { | ||
| "capacity": { | ||
| "usage": { | ||
| "bytes": 520505786368 | ||
| }, | ||
| "bytes": 1610344300544 | ||
| }, | ||
| "provisioned": { | ||
| "bytes": 520505786368 | ||
| } | ||
| }, | ||
| "capacity": { | ||
| "free": { | ||
| "bytes": 37120094208 | ||
| }, | ||
| "total": { | ||
| "bytes": 74686664704 | ||
| }, | ||
| "used": { | ||
| "bytes": 37566570496, | ||
| "pct": 0.502988996026061 | ||
| } | ||
| }, | ||
| "fstype": "OTHER", | ||
| "host": { | ||
| "count": 1, | ||
| "names": "DC0_H0" | ||
| }, | ||
| "name": "LocalDS_0", | ||
| "read": { | ||
| "bytes": 1024 | ||
| }, | ||
| "status": "green", | ||
| "vm": { | ||
| "count": 4, | ||
| "names": [ | ||
| "DC0_C0_RP0_VM0", | ||
| "DC0_C0_RP0_VM1", | ||
| "DC0_H0_VM0", | ||
| "DC0_H0_VM1" | ||
| ] | ||
| }, | ||
| "write": { | ||
| "bytes": 450560 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
58 changes: 58 additions & 0 deletions
58
packages/vsphere/data_stream/datastore/_dev/test/pipeline/test-datastore.json-expected.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| { | ||
| "expected": [ | ||
| { | ||
| "ecs": { | ||
| "version": "8.11.0" | ||
| }, | ||
| "vsphere": { | ||
| "datastore": { | ||
| "capacity": { | ||
| "free": { | ||
| "bytes": 37120094208 | ||
| }, | ||
| "total": { | ||
| "bytes": 74686664704 | ||
| }, | ||
| "used": { | ||
| "bytes": 37566570496, | ||
| "pct": 0.502988996026061 | ||
| } | ||
| }, | ||
| "disk": { | ||
| "capacity": { | ||
| "bytes": 1610344300544, | ||
| "usage": { | ||
| "bytes": 520505786368 | ||
| } | ||
| }, | ||
| "provisioned": { | ||
| "bytes": 520505786368 | ||
| } | ||
| }, | ||
| "fstype": "OTHER", | ||
| "host": { | ||
| "count": 1, | ||
| "names": "DC0_H0" | ||
| }, | ||
| "name": "LocalDS_0", | ||
| "read": { | ||
| "bytes": 1024 | ||
| }, | ||
| "status": "green", | ||
| "vm": { | ||
| "count": 4, | ||
| "names": [ | ||
| "DC0_C0_RP0_VM0", | ||
| "DC0_C0_RP0_VM1", | ||
| "DC0_H0_VM0", | ||
| "DC0_H0_VM1" | ||
| ] | ||
| }, | ||
| "write": { | ||
| "bytes": 450560 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,19 @@ streams: | |
| title: vSphere datastore metrics | ||
| description: vSphere datastore metrics | ||
| vars: | ||
| - name: period | ||
| type: text | ||
| title: Period | ||
| description: The vSphere performance API allows for collecting host and datastore metrics at various intervals, including real-time (every 20 seconds), 5 minutes, or longer durations. Properly configuring the "period" parameter is crucial to manage usage restrictions and ensure accurate data collection. For more information on optimizing your data collection setup, refer to the [Data Collection Intervals](https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.vsphere.monitoring.doc/GUID-247646EA-A04B-411A-8DD4-62A3DCFCF49B.html) and [Data Collection Levels](https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.vsphere.monitoring.doc/GUID-25800DE4-68E5-41CC-82D9-8811E27924BC.html) documentation. | ||
| default: 20s | ||
| - name: tags | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tags is not added to hbs file. |
||
| type: text | ||
| title: Tags | ||
| multi: true | ||
| required: true | ||
| show_user: false | ||
| default: | ||
| - vsphere-datastore | ||
| - name: processors | ||
| type: yaml | ||
| title: Processors | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metric_type to be added for new metrics.