Skip to content

Add docs for Fleet secrets storage (phase 1)#355

Merged
kilfoyle merged 6 commits intoelastic:mainfrom
kilfoyle:161/secrets-storage
Aug 24, 2023
Merged

Add docs for Fleet secrets storage (phase 1)#355
kilfoyle merged 6 commits intoelastic:mainfrom
kilfoyle:161/secrets-storage

Conversation

@kilfoyle
Copy link
Member

@kilfoyle kilfoyle commented Jul 26, 2023

This updates the Elastic Agent policies page to describe secret values storage, implemented via elastic/kibana#154715

I know the Kibana work is still ongoing so there's no hurry at all to review or merge this.

Preview of changes

Closes: #161

@kilfoyle kilfoyle marked this pull request as draft July 26, 2023 21:46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image is hard to read, could we add one with a higher resolution?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! This screen capture was from the demo, so I'll take a better one from the staging server as soon as the Kibana UI PR is merged.

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
@amitkanfer
Copy link
Contributor

Just noticed that the embedded image here is blurry.

@kilfoyle
Copy link
Member Author

Just noticed that the embedded image here is blurry.

@amitkanfer Thanks! I'll wait for the secrets storage UI PR to merge and then I'll grab a new screencap off of staging.

@hop-dev
Copy link
Contributor

hop-dev commented Aug 23, 2023

@kilfoyle @juliaElastic I think we should add something regarding elastic/kibana#163627

Secrets will only be stored in the new secure way if all fleet server agents are version 8.10.0 or above.

@kilfoyle
Copy link
Member Author

Thanks @hop-dev! I have a warning (see preview page) about the required Fleet Server version. Let me know if you think the wording needs any fixing up.

Screenshot 2023-08-23 at 10 35 22 AM

@hop-dev
Copy link
Contributor

hop-dev commented Aug 23, 2023

Thanks @hop-dev! I have a warning (see preview page) about the required Fleet Server version. Let me know if you think the wording needs any fixing up.

🤦 so sorry I missed that, looks great!

@kilfoyle
Copy link
Member Author

Thanks for approving @hop-dev!
Is there somewhere that I can grab a new screen capture to replace this blurry one? I took the original from your demo recording. If it's not convenient I can just take one from staging once the PR is merged.

@hop-dev
Copy link
Contributor

hop-dev commented Aug 23, 2023

@kilfoyle I've set up a cloud deployment with a test package which has secrets, here is the package policy:

https://test-4517cf.kb.us-central1.gcp.foundit.no:9243/app/fleet/policies/1898ce80-41ce-11ee-bc92-9fefea853cee/edit-integration/7e8b7b0a-d7dd-4759-bf18-fb5833d65aea

I will send the credentials separately

@kilfoyle
Copy link
Member Author

@jillguyonnet Is it alright with you if I merge this into the v8.10 docs? Here's a preview of the changes.

Copy link
Contributor

@jillguyonnet jillguyonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks David 🎉

@kilfoyle
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kilfoyle added a commit to kilfoyle/ingest-docs that referenced this pull request Aug 24, 2023
* Add docs for Fleet secrets storage (phase 1)

* Fixup

* Resize graphic

* Add warning about minimum required version

* Update docs/en/ingest-management/agent-policies.asciidoc

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>

* Update 'Package Var Secret' graphic with clearer version

---------

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
(cherry picked from commit f2d588a)
kilfoyle added a commit that referenced this pull request Aug 24, 2023
* Add docs for Fleet secrets storage (phase 1)

* Fixup

* Resize graphic

* Add warning about minimum required version

* Update docs/en/ingest-management/agent-policies.asciidoc

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>

* Update 'Package Var Secret' graphic with clearer version

---------

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
(cherry picked from commit f2d588a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Docs for secrets storage, phase 1

5 participants