This repository was archived by the owner on May 16, 2023. It is now read-only.
[filebeat] Configurable ClusterRole#978
Merged
jmlrt merged 9 commits intoelastic:masterfrom Dec 18, 2020
njgibbon:master
Merged
[filebeat] Configurable ClusterRole#978jmlrt merged 9 commits intoelastic:masterfrom njgibbon:master
jmlrt merged 9 commits intoelastic:masterfrom
njgibbon:master
Conversation
…eve there is a typo
…at. This enables easier changes and particularly enables easier addition of things like psps
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jmlrt
changed the title
jmlrt
previously approved these changes
Dec 18, 2020
Member
|
jenkins test this please |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 18, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 18, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 18, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Jan 5, 2021
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Jan 5, 2021
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
that referenced
this pull request
Jan 5, 2021
jmlrt
added a commit
that referenced
this pull request
Jan 5, 2021
Closed
This was referenced Feb 12, 2021
Merged
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlHello,
This change would make the clusterrole manageable and extendable for filebeat in the exact same way that it is for metricbeat.
This is obviously potentially useful anyway. But, the main reason I raise this is that it makes it much easier for a chart consumer to add the rule configuration for a pod security policy.
And, following the same reasoning it will make it easier for a chart contributor to add a PSP feature into the chart in the future where I see there are some github issues around this topic.