This repository was archived by the owner on May 16, 2023. It is now read-only.
[all] Simplify doc in 7.9 branch#859
Merged
nkammah merged 2 commits intoelastic:7.9from Oct 21, 2020
Merged
Conversation
nkammah
force-pushed
the
reword-warning-statements-in-readme
branch
from
45f8f9e to
eef9409
Compare
nkammah
changed the title
jmlrt
approved these changes
Oct 21, 2020
Member
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
LGTM⛴ just one comment to make release automation easier
Comment on lines
+11
to
+12
| **Warning**: This branch is used for development, please use the latest [7.9](https://github.com/elastic/helm-charts/releases) | ||
| release for released version. |
Member
There was a problem hiding this comment.
Maybe keeping this statement in a single line would make easier to automate removing it during release and adding it back after releases
Contributor
Author
There was a problem hiding this comment.
The intent with that PR is that we will not add/remove that warning statement for / after the release. Do you foresee this being an issue?
Member
There was a problem hiding this comment.
Yes this is an issue because this statement will be displayed in Artifact Hub and will make user think that released charts are for development.
jmlrt
approved these changes
Oct 21, 2020
|
|
||
| **Warning**: This branch is used for development, please use [7.9.2][https://github.com/elastic/helm-charts/releases/tag/7.9.2] release for released version. | ||
|
|
||
| **Warning**: This branch is used for development, please use the latest [7.9](https://github.com/elastic/helm-charts/releases) |
Member
There was a problem hiding this comment.
Another comment, maybe we could mention 7.x instead 7.9 see #860 (comment)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reword warning statements in chart readme to streamline the release process - related PR : #858