Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[kibana] add service.httpPortName config in chart#843

Merged
jmlrt merged 4 commits intoelastic:masterfrom
ebuildy:kibana/port
Dec 1, 2020
Merged

[kibana] add service.httpPortName config in chart#843
jmlrt merged 4 commits intoelastic:masterfrom
ebuildy:kibana/port

Conversation

@ebuildy
Copy link
Copy Markdown
Contributor

@ebuildy ebuildy commented Oct 18, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fix #841: "Kibana: Missing service.httpPortName config in chart"

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 18, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt jmlrt mentioned this pull request Nov 4, 2020
Closed
jmlrt
jmlrt suggested changes Nov 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ebuildy,

Thank you for this PR and all the others contributions you're doing to this repo's issues ❤️

There is some minor changes to do in the test file. Te rest LGTM 👍

Comment thread kibana/tests/kibana_test.py Outdated
def test_service_port_name():
r = helm_template("")

assert r["service"][name]["spec"]["ports"][0]["name"] == "http"
Copy link
Copy Markdown
Member

@jmlrt jmlrt Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this assertion to https://github.com/elastic/helm-charts/blob/master/kibana/tests/kibana_test.py#L12?

Comment thread kibana/tests/kibana_test.py
r = helm_template(config)

assert r["service"][name]["spec"]["loadBalancerIP"] == "12.5.11.79"

Copy link
Copy Markdown
Member

@jmlrt jmlrt Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black formatter requires 2 empty lines between each function.

Can you run black kibana/tests/kibana_test.py to fix it?

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Dec 1, 2020

jenkins test this please

@jmlrt jmlrt merged commit c0af9b4 into elastic:master Dec 1, 2020
@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Dec 1, 2020

I updated the python test to be able to merge the PR. Thanks for your work @ebuildy 👍

@jmlrt jmlrt added need-backport enhancement New feature or request kibana labels Dec 1, 2020
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 1, 2020
@ebuildy @jmlrt
[kibana] add service.httpPortName config in chart (elastic#843)
14ae299 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@jmlrt jmlrt mentioned this pull request Dec 1, 2020
Merged
@jmlrt jmlrt mentioned this pull request Dec 1, 2020
Merged
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 1, 2020
@ebuildy @jmlrt
[kibana] add service.httpPortName config in chart (elastic#843)
4ad3e8a 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 1, 2020
@ebuildy @jmlrt
[kibana] add service.httpPortName config in chart (elastic#843)
eebaa57 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@jmlrt jmlrt mentioned this pull request Dec 1, 2020
Merged
jmlrt added a commit that referenced this pull request Dec 1, 2020
@jmlrt @ebuildy
[6.8] [kibana] add service.httpPortName config in chart (#843) (#957)
94b6136 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

Co-authored-by: Thomas Decaux <ebuildy@gmail.com>
jmlrt added a commit that referenced this pull request Dec 1, 2020
@jmlrt @ebuildy
[7.10] [kibana] add service.httpPortName config in chart (#843) (#958)
a877a91 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

Co-authored-by: Thomas Decaux <ebuildy@gmail.com>
jmlrt added a commit that referenced this pull request Dec 1, 2020
@jmlrt @ebuildy
[7.x] [kibana] add service.httpPortName config in chart (#843) (#959)
a62852a 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

Co-authored-by: Thomas Decaux <ebuildy@gmail.com>
@elasticmachine elasticmachine mentioned this pull request Dec 9, 2020
Merged
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
Closed
This was referenced Feb 12, 2021
Closed
Merged
@jmlrt jmlrt mentioned this pull request Feb 18, 2021
Merged
@jmlrt jmlrt mentioned this pull request Mar 15, 2021
Closed
@jmlrt jmlrt mentioned this pull request Mar 18, 2021
Closed
@jmlrt jmlrt mentioned this pull request May 25, 2021
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
Merged
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmlrt jmlrt jmlrt requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported enhancement New feature or request kibana

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kibana: Missing service.httpPortName config in chart

3 participants

@ebuildy @elasticmachine @jmlrt