Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[apm-server] Add missing fields to HPA#782

Merged
jmlrt merged 5 commits intoelastic:masterfrom
david92rl:master
Dec 1, 2020
Merged

[apm-server] Add missing fields to HPA#782
jmlrt merged 5 commits intoelastic:masterfrom
david92rl:master

Conversation

@david92rl
Copy link
Copy Markdown
Contributor

@david92rl david92rl commented Aug 14, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fix #531

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt jmlrt added apm-server bug Something isn't working labels Aug 25, 2020
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Nov 23, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

jmlrt
jmlrt previously approved these changes Nov 24, 2020
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkins test this please

@botelastic botelastic Bot removed the triage/stale label Nov 24, 2020
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Nov 24, 2020

jenkins test this please

Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/651.

Can you run black <CHART>/tests/<CHART>_test.py?

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Dec 1, 2020

jenkins test this please

Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt jmlrt changed the title fix: Add missing fields to HPA in apm-server [apm-server] Add missing fields to HPA Dec 1, 2020
@jmlrt jmlrt merged commit 9da992b into elastic:master Dec 1, 2020
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit that referenced this pull request Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

Co-authored-by: David <david@dtslabs.com>
jmlrt added a commit that referenced this pull request Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

Co-authored-by: David <david@dtslabs.com>
jmlrt added a commit that referenced this pull request Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

Co-authored-by: David <david@dtslabs.com>
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Feb 12, 2021
@jmlrt jmlrt mentioned this pull request Feb 18, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

apm-server backported bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM-SERVER] doesn't deploy on k8s 1.17.0 with HorizontalPodAutoscaler enabled

3 participants