Metricbeat daemonset deployment optional

[erihanse]

• Chart version not bumped (the versions are all bumped and released at the same time)
• README.md updated with any new values or changes
• Updated template tests in ${CHART}/tests/*.py
• Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Closes #702.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[erihanse]

FYI I have signed the CLA.

[fatmcgav]

Hi @erihanse

Thank you for opening this PR.
I can see that you have indeed signed the CLA, however it appears to be under a different email address to that on the commits above, which is resulting in the commits not being correctly associated to your GitHub username.

2 options:

1. Add the email address to your GitHub profile (***@drift.oslo.kommune.no)
2. Update the commits to use the same email address as that with which you signed the CLA. (***@outlook.com)

[erihanse]

@fatmcgav ah, of course! :D Should be okay now.

[jmlrt]

jenkins test this please

[jmlrt]

Thanks for this PR 👍

That's a really valuable feature you're adding.

We have a test that daemonset exists with default values:

helm-charts/metricbeat/tests/metricbeat_test.py

Line 17 in 917187d

assert name in r["daemonset"]

Could you add the same tests for deployment?

adding assert name + "-metrics" in r["deployment"] should be enough.

The rest is OK for me.

[fatmcgav]

Jenkins test this please

[jmlrt]

LGTM⛴

[jmlrt]

backported to 6.8, 7.8and 7.x branches

[erihanse]

@jmlrt I'm sorry if I don't understand the release process, but when will these changes, including those in #387 be released?
I just want to install it without cloning the repo like this :-)

helm upgrade event-collector elastic/metricbeat \
    --install \
    --namespace monitoring \
    --version 7.8.? \
    -f our-values.yaml 

[jmlrt]

Charts are released in the same time as the rest of Elastic Stack.
This PR will be part of 6.8.11 and 7.8.1 releases.
We don't communicate publicly the releases dates but this is planned for pretty soon.