This repository was archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] _helpers.tpl - elasticsearch.endpoints to use elasticsearch.uname#670
Merged
jmlrt merged 3 commits intoelastic:masterfrom Jul 13, 2020
Merged
[elasticsearch] _helpers.tpl - elasticsearch.endpoints to use elasticsearch.uname#670jmlrt merged 3 commits intoelastic:masterfrom
jmlrt merged 3 commits intoelastic:masterfrom
Conversation
…sticsearch.uname template, in order to enable the cluster bootstrap, when fullnameOverride is configured.
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
Member
|
jenkins test this please |
…ide' is used and the 'initial_master_nodes', should be 'customfullName-{1-3}', not 'customfullName-master-{1-3}'
Contributor
Author
I have added a test case which covers the use case. |
Member
|
jenkins test this please |
jmlrt
suggested changes
Jun 25, 2020
Member
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
Some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/314.
Can you run black elasticsearch/tests/elasticsearch_test.py?
Member
|
jenkins test this please |
1 similar comment
Member
|
jenkins test this please |
jmlrt
pushed a commit
that referenced
this pull request
Jul 13, 2020
…search.uname (#670) This addressing an issue where nodes are unable to locate the masters when fullnameOverride is used, due to the cluster.initial_master_nodes having the wrong name of the nodes.
jmlrt
pushed a commit
that referenced
this pull request
Jul 13, 2020
…search.uname (#670) This addressing an issue where nodes are unable to locate the masters when fullnameOverride is used, due to the cluster.initial_master_nodes having the wrong name of the nodes.
jmlrt
pushed a commit
that referenced
this pull request
Jul 13, 2020
…search.uname (#670) This addressing an issue where nodes are unable to locate the masters when fullnameOverride is used, due to the cluster.initial_master_nodes having the wrong name of the nodes.
Member
|
backported to |
Merged
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addressing an issue where nodes are unable to locate the masters when
fullnameOverrideis used, due to thecluster.initial_master_nodeshaving the wrong name of the nodes.${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml