This repository was archived by the owner on May 16, 2023. It is now read-only.
[kibana] Add pod security policy to template #641
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| {{- if .Values.managedServiceAccount }} | ||
| apiVersion: rbac.authorization.k8s.io/v1beta1 | ||
| kind: ClusterRole | ||
|
Member
There was a problem hiding this comment. I don't think we need |
||
| metadata: | ||
| name: {{ template "kibana.serviceAccount" . }}-cluster-role | ||
| labels: | ||
| app: "{{ template "kibana.fullname" . }}" | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| heritage: {{ .Release.Service | quote }} | ||
| release: {{ .Release.Name | quote }} | ||
| rules: | ||
|
Member
There was a problem hiding this comment. a specific rule for |
||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - namespaces | ||
| - pods | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| {{- end -}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| {{- if .Values.managedServiceAccount }} | ||
| apiVersion: rbac.authorization.k8s.io/v1beta1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: {{ template "kibana.serviceAccount" . }}-cluster-role-binding | ||
| labels: | ||
| app: "{{ template "kibana.fullname" . }}" | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| heritage: {{ .Release.Service | quote }} | ||
| release: {{ .Release.Name | quote }} | ||
| roleRef: | ||
| kind: ClusterRole | ||
| name: {{ template "kibana.serviceAccount" . }}-cluster-role | ||
| apiGroup: rbac.authorization.k8s.io | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: {{ template "kibana.serviceAccount" . }} | ||
| namespace: {{ .Release.Namespace }} | ||
| {{- end -}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| {{- if .Values.podSecurityPolicy.create -}} | ||
| {{- $fullName := include "kibana.fullname" . -}} | ||
| apiVersion: policy/v1beta1 | ||
| kind: PodSecurityPolicy | ||
| metadata: | ||
| name: {{ default $fullName .Values.podSecurityPolicy.name | quote }} | ||
| labels: | ||
| heritage: {{ .Release.Service | quote }} | ||
| release: {{ .Release.Name | quote }} | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| app: {{ $fullName | quote }} | ||
| spec: | ||
| {{ toYaml .Values.podSecurityPolicy.spec | indent 2 }} | ||
| {{- end -}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| {{- if .Values.managedServiceAccount }} | ||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: {{ template "kibana.serviceAccount" . }} | ||
| labels: | ||
| app: "{{ template "kibana.fullname" . }}" | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| heritage: {{ .Release.Service | quote }} | ||
| release: {{ .Release.Name | quote }} | ||
| {{- end -}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -282,7 +282,8 @@ def test_using_a_name_override(): | |
|
|
||
| def test_setting_a_custom_service_account(): | ||
| config = """ | ||
| rbac: | ||
| serviceAccountName: notdefault | ||
| """ | ||
| r = helm_template(config) | ||
| assert ( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,7 +72,32 @@ securityContext: | |
| runAsNonRoot: true | ||
| runAsUser: 1000 | ||
|
|
||
| # Whether this chart should self-manage its service account, role, and associated role binding. | ||
| managedServiceAccount: true | ||
|
|
||
| rbac: | ||
| create: false | ||
| serviceAccountName: "" | ||
|
|
||
| podSecurityPolicy: | ||
| create: false | ||
| name: "" | ||
| spec: | ||
| privileged: true | ||
|
Member
There was a problem hiding this comment.
|
||
| fsGroup: | ||
| rule: RunAsAny | ||
| runAsUser: | ||
| rule: RunAsAny | ||
| seLinux: | ||
| rule: RunAsAny | ||
| supplementalGroups: | ||
| rule: RunAsAny | ||
| volumes: | ||
|
Member
There was a problem hiding this comment. Let's add |
||
| - secret | ||
| - configMap | ||
| - persistentVolumeClaim | ||
| - projected | ||
| - emptyDir | ||
|
|
||
| # This is the PriorityClass settings as defined in | ||
| # https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#priorityclass | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you checking
podSecurityPolicy.namevalue if you're not usingkibana.serviceAccountinkibana/templates/podsecuritypolicy.yaml?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer removing
kibana.serviceAccounttemplate and keepingClusterRole,ClusterRoleBindingandServiceAccountname consistent with what we have in most other charts (you can checkLogstashchart for that).