This repository was archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] Fix issue with readinessProbe causing outages#638
Merged
fatmcgav merged 2 commits intoelastic:masterfrom May 28, 2020
Merged
[elasticsearch] Fix issue with readinessProbe causing outages#638fatmcgav merged 2 commits intoelastic:masterfrom
readinessProbe causing outages#638fatmcgav merged 2 commits intoelastic:masterfrom
Conversation
The `readinessProbe` was updated in elastic#586, however this appears to have introduced a bug which can cause the pod to report as ready before it actually is, due to a lack of quoting around the URL query params, combined with the use of '&'. This commit reworks the `readinessProbe` to correctly quote things. Reintroduced the `http` function, and added support for passing `args` in addition to the `path`. Also borrowed the `set --` pattern from the Kibana chart.
fatmcgav
force-pushed
the
fix_readinessprobe_quoting
branch
from
7b00aa1 to
19c0904
Compare
This was referenced May 20, 2020
Contributor
Author
|
I've added a |
Crazybus
approved these changes
May 27, 2020
Contributor
Crazybus
left a comment
Crazybus
left a comment
There was a problem hiding this comment.
LGTM!
Also ran a few tests to confirm that it is behaving as expected again!
fatmcgav
pushed a commit
that referenced
this pull request
May 28, 2020
fatmcgav
pushed a commit
that referenced
this pull request
May 28, 2020
fatmcgav
pushed a commit
that referenced
this pull request
May 28, 2020
peric
pushed a commit
to kiwicom/terraform-kubernetes-elasticsearch
that referenced
this pull request
Jul 2, 2020
Closed
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
readinessProbewas updated in #586, however this appears to haveintroduced a bug which can cause the pod to report as ready before it
actually is, due to a lack of quoting around the URL query params,
combined with the use of '&'.
This commit reworks the
readinessProbeto correctly quote things.Reintroduced the
httpfunction, and added support for passingargsin addition to the
path.Also borrowed the
set --pattern from the Kibana chart.Fixes: #631
Fixes: #625
Related PR: #626
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml