Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[metricbeat] Fix configchecksum not being set#634

Merged
jmlrt merged 1 commit intoelastic:masterfrom
MaxRink:fix-metricbeat-config-checksum
May 27, 2020
Merged

[metricbeat] Fix configchecksum not being set#634
jmlrt merged 1 commit intoelastic:masterfrom
MaxRink:fix-metricbeat-config-checksum

Conversation

@MaxRink
Copy link
Copy Markdown
Contributor

@MaxRink MaxRink commented May 19, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

This tackles #632

Downside: leads to avoidable reloads of daemonset if deployment changes and vice versa

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented May 27, 2020

Hi @MaxRink, thanks for this PR 👍

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented May 27, 2020

jenkins test this please

Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt jmlrt merged commit 5eb8584 into elastic:master May 27, 2020
jmlrt pushed a commit that referenced this pull request May 27, 2020
jmlrt pushed a commit that referenced this pull request May 27, 2020
jmlrt pushed a commit that referenced this pull request May 27, 2020
@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented May 27, 2020

backported to 6.8 branch in 4d547ca
backported to 7.x branch in 8c904bb
backported to 7.7 branch in bedca1a

jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request May 27, 2020
This was referenced Jun 3, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants