Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[script] Update bumper script to handle SNAPSHOT versions#581

Merged
mgreau merged 2 commits intoelastic:7.7from
mgreau:bumper-with-snapshot
Apr 15, 2020
Merged

[script] Update bumper script to handle SNAPSHOT versions#581
mgreau merged 2 commits intoelastic:7.7from
mgreau:bumper-with-snapshot

Conversation

@mgreau
Copy link
Copy Markdown

@mgreau mgreau commented Apr 15, 2020

This commit updates the bumper.py script to handle the
workflows for updating the versions to test staging artifacts
and before a release, for example:

  • update 7.7.0-SNAPSHOT to 7.7.0 before tagging a release, by running
    env BUMPER_VERSION_7="7.7.0" ./helpers/bumper.py
  • update 7.7.0-SNAPHSHOT to 7.7.0-abcdefgh for testing staging artifacts
    by running:
    env BUMPER_VERSION_7="7.7.0-abcdefgh" BUMPER_USE_STAGING_IMAGES="true" ./helpers/bumper.py

For now, this script does not handle the bump from 7.7.0 to 7.7.1-SNAPSHOT
for the next development iteration after a release. In the meantime,
this update should be done manually.

This commit updates the `bumper.py` script to handle the
workflows for updating the versions to test staging artifacts
and before a release, for example:

- update 7.7.0-SNAPSHOT to 7.7.0 before tagging a release, by running
  `env BUMPER_VERSION_7="7.7.0" ./helpers/bumper.py`
- update 7.7.0-SNAPHSHOT to 7.7.0-abcdefgh for testing staging artifacts
by running:
  `env BUMPER_VERSION_7="7.7.0-abcdefgh" BUMPER_USE_STAGING_IMAGES="true" ./helpers/bumper.py`

For now this script do not handle the bump from 7.7.0 to 7.7.1-SNAPSHOT
for the next developement iteration after a release. In the meantime
this update should be done manually.
@mgreau mgreau requested a review from jmlrt April 15, 2020 15:25
@mgreau mgreau added the v7.7.0 label Apr 15, 2020
@mgreau mgreau self-assigned this Apr 15, 2020
@mgreau mgreau requested a review from a team April 15, 2020 15:26
Comment thread helpers/bumper.py
file_patterns = [
"*/examples/*/*.y*ml",
"helpers/examples.mk",
"*/README.md",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the README excluded?

We'll need to bump the versions in README to 7.7.0 before the release.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch I pushed c54c8c5

Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgreau mgreau merged commit 68a54af into elastic:7.7 Apr 15, 2020
@mgreau mgreau deleted the bumper-with-snapshot branch April 15, 2020 16:29
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants