Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] fix helm test command#564

Merged
jmlrt merged 1 commit intoelastic:masterfrom
jmlrt:fix-helm-test
Apr 6, 2020
Merged

[elasticsearch] fix helm test command#564
jmlrt merged 1 commit intoelastic:masterfrom
jmlrt:fix-helm-test

Conversation

@jmlrt
Copy link
Copy Markdown
Member

@jmlrt jmlrt commented Apr 6, 2020

  • remove wrong --namespace argument
  • add --cleanup to clean test pod
$ helm upgrade --wait --timeout=900 --install --values values.yaml helm-es-docker-for-mac ../../
Release "helm-es-docker-for-mac" does not exist. Installing it now.
NAME:   helm-es-docker-for-mac
LAST DEPLOYED: Mon Apr  6 15:57:23 2020
NAMESPACE: default
STATUS: DEPLOYED

...

NOTES:
1. Watch all cluster members come up.
  $ kubectl get pods --namespace=default -l app=elasticsearch-master -w
2. Test cluster health using Helm test.
  $ helm test helm-es-docker-for-mac --namespace=default

$ helm test helm-es-docker-for-mac --namespace=default
Error: unknown flag: --namespace
  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

* remove wrong `--namespace` argument
* add `--cleanup` to clean test pod
@jmlrt jmlrt added the bug Something isn't working label Apr 6, 2020
@jmlrt jmlrt requested a review from a team April 6, 2020 16:58
Copy link
Copy Markdown
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit fe92c10 into elastic:master Apr 6, 2020
@jmlrt jmlrt deleted the fix-helm-test branch April 6, 2020 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants