Giving more control on the kubeStateMetrics subchart for Metricbeat#561
Giving more control on the kubeStateMetrics subchart for Metricbeat#561iridian-ks wants to merge 1 commit intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
|
I believe I've signed the CLA. |
|
Hi @iridian-ks, |
|
Thanks @jmlrt , any chance to bring over the exports from the values? |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist. |
|
Hi @iridian-ks, sorry for the delay. I plan to work on #387 soon if it is updated.
I never used |
|
@iridian-ks #387 has been merged so I'll close this one. |
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlHello Elastic Team!
Thanks for contributing these charts to open source! We appreciate it :)
I'm hoping this could get added. We're having issues in our Prometheus instance seeing double metrics due to the kube-state-metrics chart defaulting to include the Prometheus annotations. We're running in Rancher, which also provisions kube-state-metrics so having some more control would be appreciated!
How much testing should be added here due to the nature of this change? I tried adding and running some pytests but looks like all tests are failing for a multitude of reasons.