Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Giving more control on the kubeStateMetrics subchart for Metricbeat#561

Closed
iridian-ks wants to merge 1 commit intoelastic:masterfrom
iridian-ks:master
Closed

Giving more control on the kubeStateMetrics subchart for Metricbeat#561
iridian-ks wants to merge 1 commit intoelastic:masterfrom
iridian-ks:master

Conversation

@iridian-ks
Copy link
Copy Markdown

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • [-] Updated template tests in ${CHART}/tests/*.py
  • [-] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Hello Elastic Team!

Thanks for contributing these charts to open source! We appreciate it :)

I'm hoping this could get added. We're having issues in our Prometheus instance seeing double metrics due to the kube-state-metrics chart defaulting to include the Prometheus annotations. We're running in Rancher, which also provisions kube-state-metrics so having some more control would be appreciated!

How much testing should be added here due to the nature of this change? I tried adding and running some pytests but looks like all tests are failing for a multitude of reasons.

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link
Copy Markdown

❌ Author of the following commits did not sign a Contributor Agreement:
f675de9

Please, read and sign the above mentioned agreement if you want to contribute to this project

@iridian-ks
Copy link
Copy Markdown
Author

I believe I've signed the CLA.

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Apr 6, 2020

Hi @iridian-ks,
Thanks for creating this PR, we already have #387 opened for that.

@iridian-ks
Copy link
Copy Markdown
Author

Thanks @jmlrt , any chance to bring over the exports from the values?

@jmlrt jmlrt added the enhancement New feature or request label Apr 10, 2020
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Jul 9, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Jul 9, 2020

Hi @iridian-ks, sorry for the delay.

I plan to work on #387 soon if it is updated.

Thanks @jmlrt , any chance to bring over the exports from the values?

I never used import-values but looking quickly at https://v2.helm.sh/docs/charts/#importing-child-values-via-requirements-yaml that make sense to me.

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Jul 17, 2020

@iridian-ks #387 has been merged so I'll close this one.
Feel free to create a new one for import-values.

@jmlrt jmlrt closed this Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request metricbeat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants