This repository was archived by the owner on May 16, 2023. It is now read-only.
Staging image testing#532
Merged
Conky5 merged 3 commits intoelastic:masterfrom Mar 24, 2020
Conky5:docker-registry-staging
Merged
Staging image testing#532Conky5 merged 3 commits intoelastic:masterfrom Conky5:docker-registry-staging
Conky5 merged 3 commits intoelastic:masterfrom
Conky5:docker-registry-staging
Conversation
jmlrt
previously approved these changes
Mar 20, 2020
Member
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
Just not sure that we need to run bumper script before GKE cluster creation/cleaning, the rest LGTM
| unset VAULT_ROLE_ID VAULT_SECRET_ID | ||
| set -x | ||
|
|
||
| env BUMPER_VERSION_7="$BUILD_ID" BUMPER_USE_STAGING_IMAGES="true" ./helpers/bumper.py |
Member
There was a problem hiding this comment.
Why do we need to run the bumper script before creating GKE clusters?
| unset VAULT_ROLE_ID VAULT_SECRET_ID | ||
| set -x | ||
|
|
||
| env BUMPER_VERSION_7="$BUILD_ID" BUMPER_USE_STAGING_IMAGES="true" ./helpers/bumper.py |
Member
There was a problem hiding this comment.
Why do we need to run the bumper script before cleaning GKE clusters?
Add a multijob for performing tests with staging images based on a BUILD_ID. The terraform helper now can create a docker registry secret in kubernetes. The bumper scripts now adds an `imagePullSecrets` entry to support pulling from the private registry, and additionally handling to ensure goss tests work when using BUILD_ID values as a bumped version. Allow the makefile help generator to support goals that include numbers.
Member
|
https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+cluster-creation/436/ is failing because GKE dropped K8S 1.13 support, you'll need to rebase on master to include #533 which fix CI tests. |
Contributor
Author
|
@jmlrt I've rebased and removed the extra calls to the version bump script, please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a multijob for performing tests with staging images based on a
BUILD_ID.
The terraform helper now can create a docker registry secret in
kubernetes.
The bumper scripts now adds an
imagePullSecretsentry to supportpulling from the private registry, and additionally handling to ensure
goss tests work when using BUILD_ID values as a bumped version.
Allow the makefile help generator to support goals that include
numbers.
- [ ] Chart version not bumped (the versions are all bumped and released at the same time)- [ ] README.md updated with any new values or changes- [ ] Updated template tests in${CHART}/tests/*.py- [ ] Updated integration tests in${CHART}/examples/*/test/goss.yaml