Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Accept a string as extraInitContainers value for filebeat#530

Merged
jmlrt merged 1 commit intomasterfrom
filebeat-extra-init
Mar 19, 2020
Merged

Accept a string as extraInitContainers value for filebeat#530
jmlrt merged 1 commit intomasterfrom
filebeat-extra-init

Conversation

@flaper87
Copy link
Copy Markdown
Contributor

@flaper87 flaper87 commented Mar 19, 2020

This makes the filebeat chart consistent with the other beats, while
preserving backwards compatibility.

Fixes #490

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

This makes the filebeat chart consistent with the other beats, while
preserving backwards compatibility.

Fixes #490
@flaper87 flaper87 requested a review from jmlrt March 19, 2020 16:34
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt jmlrt merged commit 6fda6d0 into master Mar 19, 2020
@jmlrt jmlrt deleted the filebeat-extra-init branch March 19, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filebeat DaemonSet renders extraInitContainers with toYaml not tpl

2 participants