Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Add compatibility for k8s 1.16#302

Merged
jmlrt merged 1 commit intoelastic:masterfrom
ckotzbauer:elastic-k8s-1.16
Oct 1, 2019
Merged

[elasticsearch] Add compatibility for k8s 1.16#302
jmlrt merged 1 commit intoelastic:masterfrom
ckotzbauer:elastic-k8s-1.16

Conversation

@ckotzbauer
Copy link
Copy Markdown
Contributor

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

I don't know if it's possible to add template tests for these changes as they are affected by Values...

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Copy Markdown
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus
Copy link
Copy Markdown
Contributor

I don't know if it's possible to add template tests for these changes as they are affected by Values...

It would be possible to add however it's going to use whatever version of helm it is being tested with. Tests are run using this docker container which is currently built with helm v2.14.

If you want to add some tests you can run make test from elasticsearch/ and it will run the template tests with the docker container.

@Crazybus
Copy link
Copy Markdown
Contributor

jenkins test this please

2 similar comments
@Crazybus
Copy link
Copy Markdown
Contributor

jenkins test this please

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Oct 1, 2019

jenkins test this please

Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt jmlrt merged commit 8aeb862 into elastic:master Oct 1, 2019
@ckotzbauer ckotzbauer deleted the elastic-k8s-1.16 branch October 1, 2019 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants