Disabling deprecation logs to be indexed

[framsouza]

Fix #1462

[mark-vieira]

LGTM but looks like this is causing some unit tests to fail due to the new default entry in elasticsearch.yml.

[jmlrt]

@framsouza I think you need to rebase your branch to 7.x upstream as there is a failing tests on K8S 1.18 in https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+cluster-creation/1626/KUBERNETES_VERSION=1.18,label=docker&&virtual/ but 1.18 CI test has been removed 2 months ago in 75a06f9#diff-3253477baaea5115041883346a02c3aeb58a2b622d803b5ebd650c489d7c3f14

[jmlrt]

As esConfig.elasticsearch.yml value is overriding the default config files in the container, we always need to answer it contains everything required.

[jmlrt]

As this will override the default elasticsearch.yml from the Docker image, we need to include cluster_name and network_host.

Suggested change

	elasticsearch.yml: |
	cluster.deprecation_indexing.enabled: false
	elasticsearch.yml: |
	cluster.name: "docker-cluster"
	network.host: 0.0.0.0
	# required for https://github.com/elastic/helm-charts/issues/1462
	cluster.deprecation_indexing.enabled: false

[jmlrt]

another way could be to include an environment variables in

helm-charts/elasticsearch/templates/statefulset.yaml

Lines 298 to 330 in fdaba22

	env:
	- name: node.name
	valueFrom:
	fieldRef:
	fieldPath: metadata.name
	{{- if has "master" .Values.roles }}
	- name: cluster.initial_master_nodes
	value: "{{ template "elasticsearch.endpoints" . }}"
	{{- end }}
	- name: node.roles
	value: "{{ template "elasticsearch.roles" . }}"
	{{- if lt (int (include "elasticsearch.esMajorVersion" .)) 7 }}
	- name: discovery.zen.ping.unicast.hosts
	value: "{{ template "elasticsearch.masterService" . }}-headless"
	{{- else }}
	- name: discovery.seed_hosts
	value: "{{ template "elasticsearch.masterService" . }}-headless"
	{{- end }}
	- name: cluster.name
	value: "{{ .Values.clusterName }}"
	- name: network.host
	value: "{{ .Values.networkHost }}"
	{{- if .Values.secret.enabled }}
	- name: ELASTIC_PASSWORD
	valueFrom:
	secretKeyRef:
	name: {{ template "elasticsearch.uname" . }}-credentials
	key: password
	{{- end }}
	{{- if .Values.esJavaOpts }}
	- name: ES_JAVA_OPTS
	value: "{{ .Values.esJavaOpts }}"
	{{- end }}

as it doesn't impact the `elasticsearch.yaml.