This repository was archived by the owner on May 16, 2023. It is now read-only.
Remove slack notification#1119
Merged
Conky5 merged 1 commit intoelastic:masterfrom Mar 23, 2021
Conky5:remove-notification
Merged
Remove slack notification#1119Conky5 merged 1 commit intoelastic:masterfrom Conky5:remove-notification
Conky5 merged 1 commit intoelastic:masterfrom
Conky5:remove-notification
Conversation
Remove the CI slack notification, these tests are too flaky and create a lot of non-actionable noise in this notification room.
jmlrt
approved these changes
Mar 23, 2021
Member
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
LGTM, I added these notifications when we had the "infra-release oncall" to triage build failures in the hope that everyone in the team would look at them during their oncall and re-run jobs for transient issues / investigate a bit or ping me for real issues, but:
- we don't have anymore the "infra-release oncall"
- I'm the only one to take a look at these failures even when we had the "infra-release oncall" and I don't need these notifications to remember to take a look regularly
- fixing these transient issues is not a priority so I don't expect jobs to be less flaky in short term.
Contributor
Author
|
Thanks for the information @jmlrt , I was thinking that is the situation we're in currently. If one of these things changes I think we can definitely add these notifications back. |
Conky5
added a commit
that referenced
this pull request
Mar 23, 2021
Remove the CI slack notification, these tests are too flaky and create a lot of non-actionable noise in this notification room. Backport of #1119
Conky5
added a commit
that referenced
this pull request
Mar 23, 2021
Remove the CI slack notification, these tests are too flaky and create a lot of non-actionable noise in this notification room. Backport of #1119
Conky5
added a commit
that referenced
this pull request
Mar 23, 2021
Remove the CI slack notification, these tests are too flaky and create a lot of non-actionable noise in this notification room. Backport of #1119
Conky5
added a commit
that referenced
this pull request
Mar 23, 2021
Remove the CI slack notification, these tests are too flaky and create a lot of non-actionable noise in this notification room. Backport of #1119
jmlrt
pushed a commit
to nflaig/helm-charts
that referenced
this pull request
Jul 6, 2021
Remove the CI slack notification, these tests are too flaky and create a lot of non-actionable noise in this notification room.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the CI slack notification, these tests are too flaky and create a
lot of non-actionable noise in this notification room.
[ ] Chart version not bumped (the versions are all bumped and released at the same time)[ ] README.md updated with any new values or changes[ ] Updated template tests in${CHART}/tests/*.py[ ] Updated integration tests in${CHART}/examples/*/test/goss.yaml