[elasticsearch] only configure ES_JAVA_OPTS when value is set by jmlrt · Pull Request #1089 · elastic/helm-charts

jmlrt · 2021-03-03T11:27:25Z

This commit update Elasticsearch Statefulset template to set
ES_JAVA_OPTS variable only when esJavaOpts value is defined.

This allow to benefit of JVM heap automatic sizing in Elasticsearch
7.11.

Fix #1083

This commit update Elasticsearch Statefulset template to set `ES_JAVA_OPTS` variable only when `esJavaOpts` value is defined. This allow to benefit of JVM heap automatic sizing in Elasticsearch 7.11. Fix elastic#1083

Conky5 · 2021-03-03T16:25:21Z

            value: "{{ .Values.clusterName }}"
          - name: network.host
            value: "{{ .Values.networkHost }}"
+          {{- if .Values.esJavaOpts  }}


It looks like there is a test asserting the default ES_JAVA_OPTS option that will need updated https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+template-testing/1218/CHART=elasticsearch,label=docker&&virtual/console

Conky5

LGTM

see elastic#1089

see #1089

see elastic#1089

…1157) see #1089 Co-authored-by: AndreasChristianson <33329956+AndreasChristianson@users.noreply.github.com>

…#1158) see #1089 Co-authored-by: AndreasChristianson <33329956+AndreasChristianson@users.noreply.github.com>

…1159) see #1089 Co-authored-by: AndreasChristianson <33329956+AndreasChristianson@users.noreply.github.com>

see elastic#1089

viceice · 2021-07-12T10:03:00Z

This broke my upgrade from 6.8.16 to 6.8.17 with constantly crashing elastice search v6

jmlrt · 2021-07-22T07:24:46Z

Hi @viceice, the upgrade from 6.8.16 to 6.8.17 with this feature was tested successfully in our CI.
Can you open a new issue with all the details to understand what problem did you add?

viceice · 2021-08-02T13:09:50Z

@jmlrt I'm using imageTag: docker.elastic.co/elasticsearch/elasticsearch:5.6.16, so it's probably a problem with the ancient es version. I can't currently switch to a newer es, because of some breakings i need so solve first.

jmlrt · 2021-08-02T13:55:28Z

Hi @viceice, without much investigation I think this may be related to the old Elasticsearch version.
Note that only 6.8.X and 7.X versions are supported with these Helm charts.
All previous versions were never tested by Elastic with these charts and we don't try to maintain any compatibility.

[elasticsearch] only configure ES_JAVA_OPTS when value is set

8081003

This commit update Elasticsearch Statefulset template to set `ES_JAVA_OPTS` variable only when `esJavaOpts` value is defined. This allow to benefit of JVM heap automatic sizing in Elasticsearch 7.11. Fix elastic#1083

jmlrt added the elasticsearch label Mar 3, 2021

jmlrt requested a review from a team March 3, 2021 11:27

mehta-ankit previously approved these changes Mar 3, 2021

View reviewed changes

Conky5 reviewed Mar 3, 2021

View reviewed changes

fix python test

e5cc1ad

jmlrt dismissed mehta-ankit’s stale review via e5cc1ad March 18, 2021 12:37

Conky5 approved these changes Mar 18, 2021

View reviewed changes

jmlrt merged commit 0ff3a3c into elastic:master Mar 18, 2021

jmlrt deleted the fix-1083 branch March 18, 2021 14:24

jmlrt added enhancement New feature or request need-backport labels Mar 18, 2021

AndreasChristianson added a commit to AndreasChristianson/helm-charts that referenced this pull request Apr 6, 2021

heap size is no longer defaulted to 1g

d648016

see elastic#1089

AndreasChristianson mentioned this pull request Apr 6, 2021

[elasticsearch] heap size is no longer defaulted to 1g #1135

Merged

4 tasks

jmlrt pushed a commit that referenced this pull request Apr 12, 2021

[elasticsearch] heap size is no longer defaulted to 1g (#1135)

d10c5f1

see #1089

jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Apr 23, 2021

[elasticsearch] heap size is no longer defaulted to 1g (elastic#1135)

e81248e

see elastic#1089

jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Apr 23, 2021

[elasticsearch] heap size is no longer defaulted to 1g (elastic#1135)

cb6467a

see elastic#1089

jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Apr 23, 2021

[elasticsearch] heap size is no longer defaulted to 1g (elastic#1135)

1dd9715

see elastic#1089

jmlrt added a commit that referenced this pull request Apr 23, 2021

[6.8] [elasticsearch] heap size is no longer defaulted to 1g (#1135) (#…

598e7ec

…1157) see #1089 Co-authored-by: AndreasChristianson <33329956+AndreasChristianson@users.noreply.github.com>

jmlrt added a commit that referenced this pull request Apr 23, 2021

[7.12] [elasticsearch] heap size is no longer defaulted to 1g (#1135) (…

cd150d4

…#1158) see #1089 Co-authored-by: AndreasChristianson <33329956+AndreasChristianson@users.noreply.github.com>

jmlrt added a commit that referenced this pull request Apr 23, 2021

[7.x] [elasticsearch] heap size is no longer defaulted to 1g (#1135) (#…

0294334

…1159) see #1089 Co-authored-by: AndreasChristianson <33329956+AndreasChristianson@users.noreply.github.com>

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request May 25, 2021

[elasticsearch] only configure ES_JAVA_OPTS when value is set (elasti…

6083e2a

…c#1089)

jmlrt mentioned this pull request May 25, 2021

[6.8] [elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089) #1210

Merged

jmlrt added the backported label May 25, 2021

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request May 25, 2021

[elasticsearch] only configure ES_JAVA_OPTS when value is set (elasti…

93734ae

…c#1089)

jmlrt mentioned this pull request May 25, 2021

[7.13] [elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089) #1211

Merged

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request May 25, 2021

[elasticsearch] only configure ES_JAVA_OPTS when value is set (elasti…

bedf294

…c#1089)

jmlrt mentioned this pull request May 25, 2021

[7.x] [elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089) #1212

Merged

jmlrt added v6.8.17 v7.13.1 labels May 25, 2021

jmlrt removed the need-backport label May 25, 2021

jmlrt added a commit that referenced this pull request May 28, 2021

[elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089) (…

b4ae7c7

…#1210)

jmlrt added a commit that referenced this pull request May 28, 2021

[elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089) (…

6063608

…#1212)

jmlrt added a commit that referenced this pull request May 28, 2021

[elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089) (…

e8e9bfc

…#1211)

elasticmachine mentioned this pull request Jun 2, 2021

7.13.1 release changelog #1237

Merged

jmlrt pushed a commit to nflaig/helm-charts that referenced this pull request Jul 6, 2021

[elasticsearch] heap size is no longer defaulted to 1g (elastic#1135)

3f3a9f0

see elastic#1089

elasticmachine mentioned this pull request Jul 8, 2021

6.8.17 release changelog #1284

Merged

elasticmachine mentioned this pull request Aug 3, 2021

7.14.0 release changelog #1318

Merged

This was referenced Dec 14, 2021

[meta] initiate 7.16 branch #1475

Merged

[kibana] optionally disable SA token automount (#1301) #1481

Merged

6.8.21 bump #1488

Merged

jmlrt mentioned this pull request Mar 8, 2022

7.17.1 bump #1609

Merged

jmlrt mentioned this pull request Apr 21, 2022

7.17.3 bump #1649

Merged

This was referenced Sep 14, 2022

[meta] fix yaml indent #1698

Merged

[meta] follow-up of #1698 #1700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[elasticsearch] only configure ES_JAVA_OPTS when value is set#1089

[elasticsearch] only configure ES_JAVA_OPTS when value is set#1089
jmlrt merged 2 commits intoelastic:masterfrom
jmlrt:fix-1083

jmlrt commented Mar 3, 2021

Uh oh!

Conky5 Mar 3, 2021

Uh oh!

Conky5 left a comment

Uh oh!

viceice commented Jul 12, 2021

Uh oh!

jmlrt commented Jul 22, 2021

Uh oh!

viceice commented Aug 2, 2021

Uh oh!

jmlrt commented Aug 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jmlrt commented Mar 3, 2021

Uh oh!

Conky5 Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

Conky5 left a comment

Choose a reason for hiding this comment

Uh oh!

viceice commented Jul 12, 2021

Uh oh!

jmlrt commented Jul 22, 2021

Uh oh!

viceice commented Aug 2, 2021

Uh oh!

jmlrt commented Aug 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants