This repository was archived by the owner on May 16, 2023. It is now read-only.
Fix formatting issue in values.yaml#1042
Closed
fmd wants to merge 1 commit intoelastic:masterfrom
Closed
Conversation
The template looks like this:
```
{{- range .Values.ingress.hosts }}
{{- if $ingressPath }}
- host: {{ . }}
http:
paths:
- path: {{ $ingressPath }}
backend:
serviceName: {{ $fullName }}
servicePort: {{ $httpPort }}
```
where `$ingressPath` is `.Values.ingress.path`
This means that following the format in the `values.yaml` doesn't work. Assuming that the template is correct, this is the fix (it works for us)
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
Member
|
Hi @fmd, You can see in the ingress template code that helm-charts/elasticsearch/templates/ingress.yaml Lines 34 to 52 in e07138c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template looks like this:
where
$ingressPathis.Values.ingress.pathThis means that following the format in the
values.yamldoesn't work. Assuming that the template is correct, this is the fix (it works for us)${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml