[elasticsearch] Make ingress hosts optional

[wouterdegeus]

This PR allows the ingress hosts definition to be made empty, which is useful for POC situations where we really don't care about hostnames, for example in GKE using an internal loadbalancer with container native loadbalancing:

service:
  annotations:
    cloud.google.com/neg: '{"ingress": true}'

ingress:
  enabled: true
  annotations:
    kubernetes.io/ingress.class: "gce-internal"
  path: /
  hosts:

Without this PR the chart would generate an ingress without rules given above config, which is not accepted by kubernetes.
With this PR it generates a proper ingress template without a hostname tied to it.

• [ x] Chart version not bumped (the versions are all bumped and released at the same time)
• [ x] README.md updated with any new values or changes
• [x ] Updated template tests in ${CHART}/tests/*.py
• Updated integration tests in ${CHART}/examples/*/test/goss.yaml

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[jmlrt]

Hi @wouterdegeus,
Thanks for opening this PR.
We'll try to review it soon. Please be patient.

[jmlrt]

Related to #536

[jmlrt]

jenkins test this please

[jmlrt]

Hi @wouterdegeus,

Since #994, you can create an ingress with empty hosts using the following values:

ingress:
  enabled: true
  annotations:
    cloud.google.com/neg: '{"ingress": true}'
  hosts:
    - host: ''
      paths:
        - path: /

I tested it and had exactly the same ingress generated as using your PR.

Can you confirm this is working for your use case?

[wouterdegeus]

Just tested, this works indeed!

[jmlrt]

Just tested, this works indeed!

Awesome 👍
Closing your PR then.