cgroup: add option to override the /sys/fs/cgroup hierarchy#148
Merged
axw merged 3 commits intoelastic:masterfrom Dec 3, 2020
Merged
cgroup: add option to override the /sys/fs/cgroup hierarchy#148axw merged 3 commits intoelastic:masterfrom
axw merged 3 commits intoelastic:masterfrom
Conversation
When running in Docker, paths in /proc/<pid>/cgroup do not correspond to the paths under /sys/fs/cgroup/<subsystem>/... Instead, the root (/sys/fs/cgroup/<subsystem/>) should be used there. Provide an option for overridding the path.
|
ping @elastic/integrations-services |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in Docker, paths in
/proc/<pid>/cgroupdo notcorrespond to the paths under
/sys/fs/cgroup/<subsystem>/...Instead, the root
/sys/fs/cgroup/<subsystem>should beused there. Provide an option for overridding the path,
similar to elastic/elasticsearch#22757.
I added NewReaderOptions/ReaderOptions to avoid breaking
the API, and to minimise breakage in the future.
Required for elastic/beats#22844