afpacket: Fix support for 32-bit x86 arch #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afpacket uses syscalls unix.SYS_GETSOCKOPT and unix.SYS_SETSOCKOPT when it needs to call [gs]etsockopt() passing a raw pointer. This doesn't work for 32-bit x86 platforms as there's no such syscall, resulting in: setsockopt packet_rx_ring: function not implemented unix.Syscall(unix.SYS_GETSOCKOPT[=366],...) = 38 // ENOSYS The correct way to call [gs]etsockopt() in this platform is to use the SYS_SOCKETCALL syscall with the right call parameter. This patch refactors the raw [gs]etsockopt() calls in afpacket to use unix.GetsockoptString and unix.SetsockoptString so that it relies on Go runtime to call the appropriate syscall.
This was referenced Nov 24, 2021
andrewkroh
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.
Depends #2.