Skip to content

Add support for nodeJS 10 pipeline api #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshdover merged 2 commits into from
Nov 5, 2018
Merged

Add support for nodeJS 10 pipeline api #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19093e7
fix(NA): add support for nodejs 10 pipeline api.
mistic Nov 5, 2018
49e9c18
chore(NA): bump version.
mistic Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions lib/monitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const Os = require('os');
const Hoek = require('hoek');
const Oppsy = require('oppsy');
const Pumpify = require('pumpify');
const { pipeline } = require('stream');

const Package = require('../package.json');
const Utils = require('./utils');
Expand Down Expand Up @@ -122,11 +123,18 @@ class Monitor {
streamObjs.unshift(new Utils.NoOp());
}

this._reporters.set(reporterName, Pumpify.obj(streamObjs)).get(reporterName).on('error', (err) => {
const combinedStreamErrHandler = (err) => {
if (err) {
console.error(`There was a problem (${err}) in ${reporterName} and it has been destroyed.`);
console.error(err);
}
}

console.error(`There was a problem (${err}) in ${reporterName} and it has been destroyed.`);
console.error(err);
});
const combinedStream = pipeline
? pipeline(...streamObjs, combinedStreamErrHandler)
: Pumpify.obj(streamObjs).on('error', combinedStreamErrHandler);

this._reporters.set(reporterName, combinedStream);
});

this._state.report = true;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@elastic/good",
"description": "Server and process monitoring plugin",
"version": "8.1.1-kibana1",
"version": "8.1.1-kibana2",
"repository": "git://github.com/elastic/good",
"main": "lib/index.js",
"keywords": [
Expand Down