-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang: enable 1.21 #310
golang: enable 1.21 #310
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
As far as I see |
ci workers are still using an old version
@@ -198,7 +198,8 @@ pipeline { | |||
|
|||
def buildImages(){ | |||
log(level: 'INFO', text: "buildImages with ${MAKEFILE} for ${PLATFORM}") | |||
withGoEnv(){ | |||
// this version is used only for preparing the templating. | |||
withGoEnv(version: '1.20.7'){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The important golang versions are defined in the dockerfiles.
This version is only required for running the go template.go in the host.
env.GO_VERSION
is used for knowing when a new release needs to happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Enable 1.21 in main since it was released in early August 2023 (https://go.dev/blog/go1.21)
Task
1.20
frommain
1.21.0
golang version1.19
to1.20
Issues
Similar to #223
Further details
See changelog for 1.21.0
@elastic/ingest-fp this is required when a new minor version is released as explained in https://github.com/elastic/golang-crossbuild#releasing-images-for-a-new-go-version. Can you please review this?