Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: enable 1.21 #310

Merged
merged 9 commits into from
Aug 16, 2023
Merged

golang: enable 1.21 #310

merged 9 commits into from
Aug 16, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 14, 2023

What

Enable 1.21 in main since it was released in early August 2023 (https://go.dev/blog/go1.21)

Task

  • Branch off 1.20 from main
  • Use 1.21.0 golang version
  • Replace 1.19 to 1.20

Issues

Similar to #223

Further details

See changelog for 1.21.0

@elastic/ingest-fp this is required when a new minor version is released as explained in https://github.com/elastic/golang-crossbuild#releasing-images-for-a-new-go-version. Can you please review this?

@v1v v1v requested a review from a team August 14, 2023 09:12
@v1v v1v self-assigned this Aug 14, 2023
@mergify
Copy link

mergify bot commented Aug 14, 2023

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link

elasticmachine commented Aug 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-14T18:39:26.449+0000

  • Duration: 123 min 34 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@v1v
Copy link
Member Author

v1v commented Aug 14, 2023

As far as I see gvm in the CI runners is not using the latest version so it cannot pick up https://github.com/andrewkroh/gvm/releases/tag/v0.5.1

@@ -198,7 +198,8 @@ pipeline {

def buildImages(){
log(level: 'INFO', text: "buildImages with ${MAKEFILE} for ${PLATFORM}")
withGoEnv(){
// this version is used only for preparing the templating.
withGoEnv(version: '1.20.7'){
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The important golang versions are defined in the dockerfiles.

This version is only required for running the go template.go in the host.

env.GO_VERSION is used for knowing when a new release needs to happen

Copy link

@amannocci amannocci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v v1v merged commit 405b729 into elastic:main Aug 16, 2023
2 checks passed
@v1v v1v deleted the feature/1.21 branch August 16, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants